-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Enabling S3 bucket share - COPY #846
Commits on Oct 30, 2023
-
Merge branch 'main' into v2m1m0
# Conflicts: # deploy/stacks/backend_stack.py # deploy/stacks/backend_stage.py # deploy/stacks/lambda_api.py # deploy/stacks/pipeline.py # template_cdk.json
Configuration menu - View commit details
-
Copy full SHA for 6d3c016 - Browse repository at this point
Copy the full SHA 6d3c016View commit details -
Feat: pivot role limit kms (#830)
### Feature or Bugfix - Feature ### Detail - read KMS keys with an alias prefixed by the environment resource prefix - read KMS keys imported in imported datasets - restrict pivot role policies to the KMS keys created by data.all and those imported in the imported datasets - move kms client from data_sharing to base as it is used in environments and datasets ### Relates - #580 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). This PR restricts the IAM policies of the pivot role, following the least privilege permissions principle - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Configuration menu - View commit details
-
Copy full SHA for 7912a24 - Browse repository at this point
Copy the full SHA 7912a24View commit details -
Make hosted_zone_id optional, code update (#812)
### Feature or Bugfix - Bugfix ### Detail - Make `hosted_zone_id` optional, code update ### Relates - #797 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A - Is the input sanitized? N/A - What precautions are you taking before deserializing the data you consume? N/A - Is injection prevented by parametrizing queries? N/A - Have you ensured no `eval` or similar functions are used? N/A - Does this PR introduce any functionality or component that requires authorization? N/A - How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A - Are you logging failed auth attempts? N/A - Are you using or adding any cryptographic features? N/A - Do you use a standard proven implementations? N/A - Are the used keys controlled by the customer? Where are they stored? N/A - Are you introducing any new policies/roles/users? N/A - Have you used the least-privilege principle? How? N/A By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. YES ### Description Make `hosted_zone_id` optional and provide `HostedZoneId` and `DNSName` in CloudFormation Stack Output, so users can create their own [Route53 AliasTarget](https://docs.aws.amazon.com/Route53/latest/APIReference/API_AliasTarget.html). Following validation checks in `ecs_patterns.ApplicationLoadBalancedFargateService` were considered: * `frontend_alternate_domain` and `userguide_alternate_domain` have to be `None` when the `hosted_zone` is `None`, see checks in [multiple-target-groups-service-base.ts#L463](https://github.com/aws/aws-cdk/blob/c445b8cc6e20d17e4a536f17262646b291a0fe36/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/network-multiple-target-groups-service-base.ts#L463), or else a `A Route53 hosted domain zone name is required to configure the specified domain name` error is raised * for a HTTPS ALB listener, only the `certificate` is ultimately required, and not the `domainName` or `domainZone`, as per evaluation logic in [application-load-balanced-service-base.ts#L509](https://github.com/aws/aws-cdk/blob/c445b8cc6e20d17e4a536f17262646b291a0fe36/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/application-load-balanced-service-base.ts#L509)
Configuration menu - View commit details
-
Copy full SHA for 55c579b - Browse repository at this point
Copy the full SHA 55c579bView commit details -
### Feature or Bugfix - Bugfix ### Detail - Clean up prints and show better exception message when custom_domain is not provided for SES ### Relates - v2.1.0 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Configuration menu - View commit details
-
Copy full SHA for 92d4324 - Browse repository at this point
Copy the full SHA 92d4324View commit details
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5fb7cf8 - Browse repository at this point
Copy the full SHA 5fb7cf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf9afc1 - Browse repository at this point
Copy the full SHA cf9afc1View commit details -
Merge branch 'v2m1m0' of https://github.com/anushka-singh/aws-dataall …
…into bucket_share
Configuration menu - View commit details
-
Copy full SHA for ddf8623 - Browse repository at this point
Copy the full SHA ddf8623View commit details -
Merge branch 'v2m1m0' into anu-s3-copy
# Conflicts: # backend/dataall/modules/datasets/services/dataset_service.py
Configuration menu - View commit details
-
Copy full SHA for a05e548 - Browse repository at this point
Copy the full SHA a05e548View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1365e92 - Browse repository at this point
Copy the full SHA 1365e92View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbcfbd5 - Browse repository at this point
Copy the full SHA bbcfbd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e8cdf1 - Browse repository at this point
Copy the full SHA 9e8cdf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d90797 - Browse repository at this point
Copy the full SHA 5d90797View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94be491 - Browse repository at this point
Copy the full SHA 94be491View commit details -
Configuration menu - View commit details
-
Copy full SHA for cff577f - Browse repository at this point
Copy the full SHA cff577fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ff80fb - Browse repository at this point
Copy the full SHA 5ff80fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3383166 - Browse repository at this point
Copy the full SHA 3383166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed96af - Browse repository at this point
Copy the full SHA 7ed96afView commit details -
Configuration menu - View commit details
-
Copy full SHA for c051896 - Browse repository at this point
Copy the full SHA c051896View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5d62d7 - Browse repository at this point
Copy the full SHA f5d62d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3783a95 - Browse repository at this point
Copy the full SHA 3783a95View commit details -
Configuration menu - View commit details
-
Copy full SHA for dacba14 - Browse repository at this point
Copy the full SHA dacba14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b404cd - Browse repository at this point
Copy the full SHA 3b404cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d0fe68 - Browse repository at this point
Copy the full SHA 5d0fe68View commit details