Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Enabling S3 bucket share - COPY #846

Closed
wants to merge 23 commits into from
Closed

Test Enabling S3 bucket share - COPY #846

wants to merge 23 commits into from

Commits on Oct 30, 2023

  1. Merge branch 'main' into v2m1m0

    # Conflicts:
    #	deploy/stacks/backend_stack.py
    #	deploy/stacks/backend_stage.py
    #	deploy/stacks/lambda_api.py
    #	deploy/stacks/pipeline.py
    #	template_cdk.json
    dlpzx authored and anushka-singh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6d3c016 View commit details
    Browse the repository at this point in the history
  2. Feat: pivot role limit kms (#830)

    ### Feature or Bugfix
    - Feature
    
    ### Detail
    - read KMS keys with an alias prefixed by the environment resource
    prefix
    - read KMS keys imported in imported datasets
    - restrict pivot role policies to the KMS keys created by data.all and
    those imported in the imported datasets
    - move kms client from data_sharing to base as it is used in
    environments and datasets
    
    ### Relates
    - #580
    
    ### Security
    Please answer the questions below briefly where applicable, or write
    `N/A`. Based on
    [OWASP 10](https://owasp.org/Top10/en/).
    
    This PR restricts the IAM policies of the pivot role, following the
    least privilege permissions principle
    
    - Does this PR introduce or modify any input fields or queries - this
    includes
    fetching data from storage outside the application (e.g. a database, an
    S3 bucket)?
      - Is the input sanitized?
    - What precautions are you taking before deserializing the data you
    consume?
      - Is injection prevented by parametrizing queries?
      - Have you ensured no `eval` or similar functions are used?
    - Does this PR introduce any functionality or component that requires
    authorization?
    - How have you ensured it respects the existing AuthN/AuthZ mechanisms?
      - Are you logging failed auth attempts?
    - Are you using or adding any cryptographic features?
      - Do you use a standard proven implementations?
      - Are the used keys controlled by the customer? Where are they stored?
    - Are you introducing any new policies/roles/users?
      - Have you used the least-privilege principle? How?
    
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    dlpzx authored and anushka-singh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7912a24 View commit details
    Browse the repository at this point in the history
  3. Make hosted_zone_id optional, code update (#812)

    ### Feature or Bugfix
    - Bugfix
    
    ### Detail
    - Make `hosted_zone_id` optional, code update
    
    ### Relates
    - #797 
    
    ### Security
    Please answer the questions below briefly where applicable, or write
    `N/A`. Based on
    [OWASP 10](https://owasp.org/Top10/en/).
    
    - Does this PR introduce or modify any input fields or queries - this
    includes
    fetching data from storage outside the application (e.g. a database, an
    S3 bucket)? N/A
      - Is the input sanitized? N/A
    - What precautions are you taking before deserializing the data you
    consume? N/A
      - Is injection prevented by parametrizing queries? N/A
      - Have you ensured no `eval` or similar functions are used? N/A
    - Does this PR introduce any functionality or component that requires
    authorization? N/A
    - How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    N/A
      - Are you logging failed auth attempts? N/A
    - Are you using or adding any cryptographic features? N/A
      - Do you use a standard proven implementations? N/A
    - Are the used keys controlled by the customer? Where are they stored?
    N/A
    - Are you introducing any new policies/roles/users? N/A
      - Have you used the least-privilege principle? How? N/A
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license. YES
    
    ### Description
    
    Make `hosted_zone_id` optional and provide `HostedZoneId` and `DNSName`
    in CloudFormation Stack Output, so users can create their own [Route53
    AliasTarget](https://docs.aws.amazon.com/Route53/latest/APIReference/API_AliasTarget.html).
    
    Following validation checks in
    `ecs_patterns.ApplicationLoadBalancedFargateService` were considered:
    * `frontend_alternate_domain` and `userguide_alternate_domain` have to
    be `None` when the `hosted_zone` is `None`, see checks in
    [multiple-target-groups-service-base.ts#L463](https://github.com/aws/aws-cdk/blob/c445b8cc6e20d17e4a536f17262646b291a0fe36/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/network-multiple-target-groups-service-base.ts#L463),
    or else a `A Route53 hosted domain zone name is required to configure
    the specified domain name` error is raised
    * for a HTTPS ALB listener, only the `certificate` is ultimately
    required, and not the `domainName` or `domainZone`, as per evaluation
    logic in
    [application-load-balanced-service-base.ts#L509](https://github.com/aws/aws-cdk/blob/c445b8cc6e20d17e4a536f17262646b291a0fe36/packages/aws-cdk-lib/aws-ecs-patterns/lib/base/application-load-balanced-service-base.ts#L509)
    lorchda authored and anushka-singh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    55c579b View commit details
    Browse the repository at this point in the history
  4. Clean-up for v2.1 (#843)

    ### Feature or Bugfix
    - Bugfix
    
    ### Detail
    - Clean up prints and show better exception message when custom_domain
    is not provided for SES
    
    ### Relates
    - v2.1.0
    
    ### Security
    Please answer the questions below briefly where applicable, or write
    `N/A`. Based on
    [OWASP 10](https://owasp.org/Top10/en/).
    
    - Does this PR introduce or modify any input fields or queries - this
    includes
    fetching data from storage outside the application (e.g. a database, an
    S3 bucket)?
      - Is the input sanitized?
    - What precautions are you taking before deserializing the data you
    consume?
      - Is injection prevented by parametrizing queries?
      - Have you ensured no `eval` or similar functions are used?
    - Does this PR introduce any functionality or component that requires
    authorization?
    - How have you ensured it respects the existing AuthN/AuthZ mechanisms?
      - Are you logging failed auth attempts?
    - Are you using or adding any cryptographic features?
      - Do you use a standard proven implementations?
      - Are the used keys controlled by the customer? Where are they stored?
    - Are you introducing any new policies/roles/users?
      - Have you used the least-privilege principle? How?
    
    
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache 2.0 license.
    dlpzx authored and anushka-singh committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    92d4324 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    5fb7cf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf9afc1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddf8623 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'v2m1m0' into anu-s3-copy

    # Conflicts:
    #	backend/dataall/modules/datasets/services/dataset_service.py
    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a05e548 View commit details
    Browse the repository at this point in the history
  5. Revert overwrites 2.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    1365e92 View commit details
    Browse the repository at this point in the history
  6. Revert overwrites 3.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    bbcfbd5 View commit details
    Browse the repository at this point in the history
  7. Revert overwrites 4.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9e8cdf1 View commit details
    Browse the repository at this point in the history
  8. Revert overwrites 4.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5d90797 View commit details
    Browse the repository at this point in the history
  9. Revert overwrites 5.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    94be491 View commit details
    Browse the repository at this point in the history
  10. Revert overwrites 6.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cff577f View commit details
    Browse the repository at this point in the history
  11. Revert overwrites 7.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5ff80fb View commit details
    Browse the repository at this point in the history
  12. Revert overwrites 7.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3383166 View commit details
    Browse the repository at this point in the history
  13. Revert overwrites 8.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7ed96af View commit details
    Browse the repository at this point in the history
  14. Revert overwrites 9.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c051896 View commit details
    Browse the repository at this point in the history
  15. Revert overwrites 10.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f5d62d7 View commit details
    Browse the repository at this point in the history
  16. Revert overwrites 11.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3783a95 View commit details
    Browse the repository at this point in the history
  17. Revert overwrites 12.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    dacba14 View commit details
    Browse the repository at this point in the history
  18. Revert overwrites 13.

    dlpzx committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3b404cd View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    5d0fe68 View commit details
    Browse the repository at this point in the history