Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Reopen tcp keep-alive for MySQL #10641

Closed
2 tasks done
yufan022 opened this issue Mar 18, 2023 · 1 comment · Fixed by #10642
Closed
2 tasks done

bug: Reopen tcp keep-alive for MySQL #10641

yufan022 opened this issue Mar 18, 2023 · 1 comment · Fixed by #10642
Labels
C-bug Category: something isn't working

Comments

@yufan022
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Version

1.0.21

What's Wrong?

image

image

Connection cannot be released because there is no keep-alive.

We need to rollback socket2 to 0.4, and reopen keep-alive.

See rust-lang/socket2#402, and wait tokio-rs/tokio#5514.

How to Reproduce?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@yufan022 yufan022 added the C-bug Category: something isn't working label Mar 18, 2023
@yufan022 yufan022 mentioned this issue Mar 18, 2023
Merged
@dantengsky
Copy link
Member

We need to rollback socket2 to 0.4, and reopen keep-alive.

See rust-lang/socket2#402, and wait tokio-rs/tokio#5514.

@yufan022 👍 thanks

@mergify mergify bot closed this as completed in #10642 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(query): Reopen keep-alive for MySQL & rollback socket2 to 0.4 yufan022/databend
2 participants
@dantengsky @yufan022