Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: TransformExchangeAggregateSerializer did not serialize all data from iterator #15049

Closed
sundy-li opened this issue Mar 20, 2024 · 0 comments · Fixed by #15031
Closed

bug: TransformExchangeAggregateSerializer did not serialize all data from iterator #15049

sundy-li opened this issue Mar 20, 2024 · 0 comments · Fixed by #15031
Labels
C-bug Category: something isn't working

Comments

@sundy-li
Copy link
Member

sundy-li commented Mar 20, 2024 •
edited
Loading

Summary

The transform_exchange_group_by_serializer and transform_exchange_aggregate_serializer just call a simple stream.next() to consume the iterator so it's most likely loss data in cluster query with group aggregation.

https://github.com/datafuselabs/databend/blob/83c68ae303bb9fee0db2b12a1164cd968dfa3e4a/src/query/service/src/pipelines/processors/transforms/aggregator/serde/transform_exchange_group_by_serializer.rs#L232-L252
@sundy-li sundy-li mentioned this issue Mar 20, 2024
Merged
11 tasks
@sundy-li sundy-li added the C-bug Category: something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(query): improve group sundy-li/databend
1 participant
@sundy-li