Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic aggregate function state #1214

Merged
merged 6 commits into from
Jul 29, 2021

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jul 28, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  • Use Generic state representation instead of DataValue
  • Merge min and max functions into the same file.
  • Introduce common/io crate, now we have BinarySer and BinaryDe for state serde.

Changelog

  • Improvement
  • Performance Improvement

Related Issues

Fixes #1189
Fixes #1215

Prepare of #966

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added pr-doc-fix pr-feature this PR introduces a new feature to the codebase labels Jul 28, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-performance labels Jul 28, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@sundy-li sundy-li added pr-improvement and removed pr-build this PR changes build/testing/ci steps pr-doc-fix labels Jul 28, 2021
@sundy-li sundy-li marked this pull request as ready for review July 28, 2021 10:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1214 (c5e2fca) into master (65e8c73) will increase coverage by 0%.
The diff coverage is 78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1214    +/-   ##
=======================================
  Coverage      72%     72%            
=======================================
  Files         456     464     +8     
  Lines       27192   27436   +244     
=======================================
+ Hits        19581   19834   +253     
+ Misses       7611    7602     -9     
Impacted Files Coverage Δ
common/datavalues/src/data_df_type.rs 25% <ø> (ø)
common/datavalues/src/data_value.rs 38% <0%> (-3%) ⬇️
...unctions/src/aggregates/aggregate_combinator_if.rs 48% <0%> (+1%) ⬆️
...mon/functions/src/aggregates/aggregate_function.rs 100% <ø> (ø)
...es/transforms/transform_aggregator_partial_test.rs 96% <ø> (ø)
...c/pipelines/transforms/transform_group_by_final.rs 74% <ø> (ø)
...pipelines/transforms/transform_group_by_partial.rs 71% <ø> (ø)
...ines/transforms/transform_group_by_partial_test.rs 96% <ø> (ø)
...ns/src/aggregates/aggregate_combinator_distinct.rs 58% <4%> (-3%) ⬇️
common/io/src/binary_ser.rs 50% <50%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e8c73...c5e2fca. Read the comment docs.

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me.

Copy link
Contributor

@jyizheng jyizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@@ -0,0 +1,13 @@
[package]
name = "common-io"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the users of this package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1215

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @sundy-li

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit b6d9835 into databendlabs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common/io crate to have bianary serde Reduce the memory size of AggregateFunction state
6 participants