chore(query): test for enable_experimental_aggregate_hashtable = 1 #14564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freejww
changed the title
github-actions
bot
added
the
pr-chore
Freejww
added
ci-benchmark
Docker Image for PR
|
added 5 commits
February 2, 2024 14:45
sundy-li
reviewed
Feb 2, 2024
| @@ -149,6 +149,10 @@ impl<Method: HashMethodBounds> AccumulatingTransform for TransformPartialGroupBy | |||
| const NAME: &'static str = "TransformPartialGroupBy"; | |||
|
|
|||
| fn transform(&mut self, block: DataBlock) -> Result<Vec<DataBlock>> { | |||
| if block.is_empty() { | |||
There was a problem hiding this comment.
I think you did not find the key reason for this bug.
Why the tests failed when you enable enable_experimental_aggregate_hashtable yet it succeeded without this config ? There must be some bug inside the new agg.
added 3 commits
February 19, 2024 09:07
…fix/agghashtable_test
…tabend into fix/agghashtable_test
|
continue in #14544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Fix the decimal type mismatch and a bug related to
set enable_experimental_aggregate_hashtable=1;.Tests
Type of change
This change is