-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical types #1648
Logical types #1648
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Works now:
|
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
======================================
- Coverage 73% 73% -1%
======================================
Files 544 564 +20
Lines 33132 33085 -47
======================================
- Hits 24437 24362 -75
- Misses 8695 8723 +28
Continue to review full report at Codecov.
|
The cached building is broken |
I have updated the cache key. |
Still not working, @PsiACE may help :) |
set |
In this barnch, it's already |
@PsiACE
Not sure how to clean the cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI Passed |
1 similar comment
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
tasks:
ARROW::extension::name
in field's metadata, extension typesDataArray
/DataValue
will be related only with physical types, soDateTime32
andUInt32
will share same physical array inside.DataArray<T>
Date16
,Date32
,DateTime32
typesnow()
,today()
functionsSummary about this PR
Changelog
Related Issues
Fixes #1627
Test Plan
Unit Tests
Stateless Tests