Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toStartOfQuarter,toStartOfMonth #1848

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

dust1
Copy link
Contributor

@dust1 dust1 commented Sep 15, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Summary about this PR

Changelog

  • Improvement

Related Issues

Fixes #853

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #1848 (f50a257) into master (a569ba3) will decrease coverage by 0%.
The diff coverage is 53%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1848   +/-   ##
======================================
- Coverage      70%     70%   -1%     
======================================
  Files         635     635           
  Lines       37824   37878   +54     
======================================
+ Hits        26514   26551   +37     
- Misses      11310   11327   +17     
Impacted Files Coverage Δ
...mon/functions/src/scalars/dates/number_function.rs 51% <33%> (+2%) ⬆️
common/functions/src/scalars/dates/date_test.rs 91% <91%> (+<1%) ⬆️
common/functions/src/scalars/dates/date.rs 60% <100%> (+2%) ⬆️
store/src/api/http_service.rs 14% <0%> (-62%) ⬇️
common/datavalues/src/columns/arithmetic.rs 63% <0%> (-13%) ⬇️
store/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
common/datavalues/src/types/data_type_coercion.rs 56% <0%> (-2%) ⬇️
common/datavalues/src/series/series_impl.rs 84% <0%> (-2%) ⬇️
query/src/sql/plan_parser.rs 74% <0%> (-1%) ⬇️
common/clickhouse-srv/src/types/mod.rs 0% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a569ba3...f50a257. Read the comment docs.

@dust1 dust1 marked this pull request as ready for review September 16, 2021 01:05
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 8001f18 into databendlabs:master Sep 16, 2021
@sundy-li
Copy link
Member

@dust1

BTW, we should not use Fixes #xxx in the issue if it did not fixes all ..

@dust1
Copy link
Contributor Author

dust1 commented Sep 16, 2021

BTW, we should not use Fixes #xxx in the issue if it did not fixes all ..

ok.

@dust1 dust1 deleted the dust1/issues853 branch September 16, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[functions] Functions Working with Date/DateTime
4 participants