Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] apply the new test style to common-management #2792

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 15, 2021

Signed-off-by: Chojan Shang psiace@outlook.com

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[test] apply the new test style to common-management

Changelog

  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Related #1866

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Chojan Shang <psiace@outlook.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #2792 (b0c5ec5) into main (2cbfa94) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2792    +/-   ##
======================================
- Coverage     69%     69%    -1%     
======================================
  Files        601     597     -4     
  Lines      32728   32242   -486     
======================================
- Hits       22801   22311   -490     
- Misses      9927    9931     +4     
Impacted Files Coverage Δ
common/meta/types/src/user_quota.rs 20% <0%> (-60%) ⬇️
common/meta/types/src/user_privilege.rs 33% <0%> (-34%) ⬇️
common/meta/types/src/match_seq.rs 71% <0%> (-29%) ⬇️
common/management/src/user/user_api.rs 69% <0%> (-27%) ⬇️
common/meta/types/src/seq_value.rs 75% <0%> (-19%) ⬇️
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
query/src/interpreters/interpreter_use_database.rs 92% <0%> (-8%) ⬇️
query/src/interpreters/interpreter_insert_into.rs 87% <0%> (-7%) ⬇️
query/src/datasources/table/fuse/table_test.rs 94% <0%> (-2%) ⬇️
...y/src/datasources/table/fuse/index/min_max_test.rs 91% <0%> (-1%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbfa94...b0c5ec5. Read the comment docs.

@BohuTANG
Copy link
Member

/lgtm

@BohuTANG BohuTANG merged commit a1f2078 into databendlabs:main Nov 15, 2021
@PsiACE PsiACE deleted the management-tests branch November 29, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants