Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you please promisify this #5

Open
oscarmorrison opened this issue Jul 28, 2017 · 5 comments
Open

can you please promisify this #5

oscarmorrison opened this issue Jul 28, 2017 · 5 comments

Comments

@oscarmorrison
Copy link

No description provided.

@svperfecta
Copy link

Very much agreed. This doesn't really follow the normal callback pattern (returning an error) or the promise pattern. It's pretty difficult to handle errors.

@seanforyou23
Copy link

Just wanted to +1 this issue and mention there's still some desire out there for this type of enhancement 😄

@VladaPetrovic
Copy link
Member

We are happy to accept any PR moving this forward.

@seanforyou23
Copy link

I will take a stab at it this week - no promises! Actually, promises will likely be involved.. you know what I mean 😉

@seanforyou23
Copy link

Hi there, just an update - I did spend some time working on this. It looks to be a good bit of work, and I ran into quite a few little things here and there that I wasn't sure about. The test suite overrides the _pushJSONRequest prototype instead of exercising the one exported from the main lib (which I'm sure is intentional) but it leaves me having trouble understanding how to ensure the integrity of the api parts after making changes without making significant modifications to both the lib and test suite. I think it may be over my head, I'm sorry - was hoping to be able to knock this out for you guys but I think it's more than I can do in isolation. I was thinking it was just a matter of wrapping the calls in Promise interface, which I've done many times, but this one got the best of me for the moment. Just wanted to mention so nobody is waiting/expecting a PR from me on this one. Sorry I couldn't be of more help on this one :/ I may try again at some point in the future in case I find more time and nobody beats me to it. Until then, best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants