Fix issue #58 : Add PNG to the mix #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobturneruk
suggested changes
Aug 16, 2022
There was a problem hiding this comment.
Thanks for this. It's a really good addition.
I think the terms "RGBA", "luminance" and "palette" are newly introduced to the lesson by this text. I think these could be removed for the list of PNG features and the value of this new text retained, but that's my subjective opinion. Otherwise, please will you define the terms, either here or in the glossary?
| @@ -163,7 +163,7 @@ In this case, the `.tif` extension causes the image to be saved as a TIFF. | |||
| > the dimensions we want the new image to have, `new_shape`. | |||
| > | |||
| > Image files on disk are normally stored as whole numbers for space efficiency, | |||
| > but tranformations and other math operations often result in | |||
| > but transformations and other math operations often result in | |||
…entific applications.
|
I simplified the explanation slightly, but chose to add a definition of a luminance channel, since #211 touches upon the important concept of single channel data(We also heard that at CarpentryCon) |
bobturneruk
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Thanks @CaptainSifff! I've made a little suggestion - hopefully I've understood what is meant by luminance right.
Co-authored-by: bobturneruk <34244196+bobturneruk@users.noreply.github.com>
uschille
approved these changes
Aug 20, 2022
Closed
zkamvar
pushed a commit
that referenced
this pull request
Apr 25, 2023
Fix issue #58 : Add PNG to the mix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've fixed a typo and added a section on PNG in order to improve issue #58