updates to work with modern Python (3.11+) #145
Conversation
updated version to 1.8.6 updated tox list updated version of pyenv-tox updated pyenvs updated to 2.0.2 updated to 2.0.3 - removed tox-pyenv updated to 2.0.3 - removed tox-pyenv remove py310 remove py311 updated pytest updated coverage and flake8 versions updated flake8 version skipping coverage moved off of deprecated try only py 3.12 updated testing dependencies added 3.8 and 3.9 back in removed python 3.8, and updated CONTRIBUTING with better test function
| @@ -2,7 +2,7 @@ version: 2.1 | |||
|
|
|||
| resources: | |||
| base_docker_image: &base_docker_image | |||
| image: 621799806001.dkr.ecr.us-east-1.amazonaws.com/pyenv-tox:1.0.0 | |||
| image: 621799806001.dkr.ecr.us-east-1.amazonaws.com/pyenv-tox:2.0.3 | |||
There was a problem hiding this comment.
updated container with python 3.11 and 3.12 environments
| @@ -64,10 +64,12 @@ commands: | |||
| - tox_cache-{{ checksum "tox.ini" }} | |||
| - run: | |||
| name: pyenv setup | |||
| command: pyenv local 2.7.16 3.5.7 3.6.8 3.7.12 3.8.12 3.9.10 3.10.2 | |||
| command: pyenv local 3.8.19 3.9.19 3.10.14 3.11.8 3.12.2 | |||
There was a problem hiding this comment.
setup 3.8-3.12 envs
There was a problem hiding this comment.
note, we don't actually run against 3.8, that is fine.
| - run: | ||
| name: tox | ||
| command: tox --pre | ||
| environment: | ||
| VIRTUALENV_DISCOVERY: pyenv |
There was a problem hiding this comment.
this environment variable is needed to migrate off of tox-pyenv per instructions here:
https://github.com/tox-dev/tox-pyenv/tree/master?tab=readme-ov-file#tox-pyenv
| @@ -32,7 +32,7 @@ $ pip install -e . | |||
| Run tests: | |||
|
|
|||
| ```sh | |||
| $ python setup.py test | |||
| $ tox --pre | |||
There was a problem hiding this comment.
python setup.py test is deprecated:
| @@ -35,7 +35,7 @@ | |||
| ) | |||
| from datadotworld.datadotworld import DataDotWorld, UriParam # noqa: F401 | |||
|
|
|||
| __version__ = '1.8.5' | |||
| __version__ = '2.0.0a' | |||
There was a problem hiding this comment.
updating this to 2.0.0a, since this is backwards-incompatible (removes support for Python < 3.9)
"a" because this really is the minimal set of changes I could find to successfully build on python 3.12 - there's a bunch more modernization we COULD do here, and we may want to do at least a little of that before committing to 2.0.0 proper.
|
I should also note, I think it's fine to support only Python 3.9+ based on this: https://devguide.python.org/versions/ 3.8 is nearing the end of it's "security" level support as a python, period, and version 1.8.5 will still work fine for anyone stuck there. If we absolutely had to for a critical customer need, we could fix defects against that version and release - and the probability of having to do that is very low. |
updated version to 1.8.6
updated version of pyenv-tox
updated pyenvs
updated to 2.0.3 - removed tox-pyenv
updated pytest
updated coverage and flake8 versions
updated testing dependencies
updated CONTRIBUTING with better test function