Test DDL #161
Merged
Test DDL #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmturner
commented
Sep 24, 2024
Comment on lines
-34
to
-41
| pub struct Query { | ||
| sql: String, | ||
| results: Option<Vec<RecordBatch>>, | ||
| num_rows: Option<usize>, | ||
| error: Option<String>, | ||
| execution_time: Duration, | ||
| execution_stats: Option<ExecutionStats>, | ||
| } |
There was a problem hiding this comment.
Query was no longer used
matthewmturner
commented
Sep 24, 2024
| query_results_state: Option<RefCell<TableState>>, | ||
| result_batches: Option<Vec<RecordBatch>>, | ||
| results_page: Option<usize>, | ||
| execution_error: Option<ExecutionError>, | ||
| execution_task: Option<JoinHandle<Result<()>>>, |
There was a problem hiding this comment.
Playing with the test code made me realize this would be useful to have for long running queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test for running
AppEvent::ExecuteDDLand then running query to make sure the DDL statements were correctly processed.Unfortunately, this isnt a proper end to end test like I was hoping. It was surprisingly difficult to get the app event loop to run in the test which is required to get that to work. So, we simply execute a query directly on the context instead.