Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metadata) Addressing vulnerabilities #10296

Merged
merged 15 commits into from
Apr 19, 2024
Merged

chore(metadata) Addressing vulnerabilities #10296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ff45853
Reason: https://cwe.mitre.org/data/definitions/327.html
rtekal Apr 15, 2024
8b1e9aa
Reason: https://cwe.mitre.org/data/definitions/338.html
rtekal Apr 15, 2024
f822476
Typo in regular expression
rtekal Apr 15, 2024
0621602
Resolves: https://cwe.mitre.org/data/definitions/20.html
rtekal Apr 15, 2024
454a90b
Do not have passwords
rtekal Apr 15, 2024
c6f702a
No password in sources
rtekal Apr 15, 2024
06acc85
Use security verify given in config
rtekal Apr 15, 2024
38a6ca1
Ensure secure request
rtekal Apr 15, 2024
72e5d0e
Resolves: https://cwe.mitre.org/data/definitions/116.html
rtekal Apr 15, 2024
cb44fa8
Merge branch 'master' into rtekal-vulnerabilities
rtekal Apr 16, 2024
6e98bbb
Merge branch 'master' into rtekal-vulnerabilities
rtekal Apr 16, 2024
2bc29f8
Merge branch 'master' into rtekal-vulnerabilities
rtekal Apr 16, 2024
c5b5284
Merge branch 'master' into rtekal-vulnerabilities
rtekal Apr 18, 2024
708f538
Reverted some commits since they are coming from #10296
rtekal Apr 18, 2024
6c5c95a
Revert as the commit comes from #10296
rtekal Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/docs/sources/presto/presto_recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source:

# Credentials
username: foo
password: datahub
password: password

sink:
# sink configs
2 changes: 1 addition & 1 deletion metadata-ingestion/docs/sources/trino/trino_recipe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source:

# Credentials
username: foo
password: datahub
password: password

# If you need to connect to Trino over http and not https, uncomment this section.
# options:
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/powerbi_report_server/report_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def requests_get(self, url_http: str, url_https: str, content_type: str) -> Any:
response = requests.get(
url=url_https,
auth=self.get_auth_credentials,
verify=False,
verify=True,
)
except ConnectionError:
LOGGER.info("Request to Report URL={}".format(url_http))
Expand Down
4 changes: 2 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/pulsar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def __init__(self, config: PulsarSourceConfig, ctx: PipelineContext):
f"{self.config.issuer_url}/.well-known/openid-configuration"
)
oid_config_response = requests.get(
oid_config_url, verify=False, allow_redirects=False
oid_config_url, verify=self.session.verify, allow_redirects=False
)

if oid_config_response:
Expand Down Expand Up @@ -163,7 +163,7 @@ def get_access_token(self) -> str:
token_response = requests.post(
url=token_endpoint,
data=data,
verify=False,
verify=self.session.verify,
allow_redirects=False,
auth=(
self.config.client_id,
Expand Down
Loading