feat(ingest/metabase): add ability to exclude other users collections #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
|
Related to issue #10328 |
paguos
force-pushed
the
feat/metabase-excluse-other-users
branch
2 times, most recently
from
ed8d984
to
8054f28
Compare
hsheth2
reviewed
Apr 18, 2024
| @@ -79,6 +79,10 @@ class MetabaseConfig(DatasetLineageProviderConfigBase): | |||
| default="public", | |||
| description="Default schema name to use when schema is not provided in an SQL query", | |||
| ) | |||
| exclude_other_user_collections: str = Field( | |||
There was a problem hiding this comment.
this should be a bool type here
| @@ -209,6 +213,7 @@ def emit_dashboard_mces(self) -> Iterable[MetadataWorkUnit]: | |||
| try: | |||
| collections_response = self.session.get( | |||
| f"{self.config.connect_uri}/api/collection/" | |||
| f"?exclude-other-user-collections={self.config.exclude_other_user_collections}" | |||
There was a problem hiding this comment.
and then we can json.dumps the bool value to convert it to false or true
paguos
force-pushed
the
feat/metabase-excluse-other-users
branch
2 times, most recently
from
ec01c6c
to
f72cb62
Compare
Signed-off-by: Pablo Osinaga <pablo.osinaga@deepl.com>
paguos
force-pushed
the
feat/metabase-excluse-other-users
branch
from
f72cb62
to
cc3eb5a
Compare
|
@hsheth2 thank you for the review!
I amend my commit, so its difficult to see the changes (sorry). |
hsheth2
approved these changes
Apr 19, 2024
hsheth2
added
the
merge-pending-ci
hsheth2
changed the title
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10328
Checklist