fix(ingestion): Explicitly set requirement on snowflake-connector-python to be newer or equal to 3.4.0 #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon to be newer or equal to 3.4.0
github-actions
bot
added
ingestion
hsheth2
approved these changes
May 8, 2024
hsheth2
added
the
merge-pending-ci
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…hon to be newer or equal to 3.4.0 (datahub-project#10445) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem appearing in
snowflake-connector-pythonbefore version3.4.0due to its internal dependency onoscryptolibrary which malfunctioned ifopensslversion contained more than 2 digits for either major, minor or patch number (see details). Version3.4.0ofsnowflake-connector-pythondrops dependency onoscryptoand therefor fixes the problem. There was already an issue raised last year to address this: #9192 and image which was built and released back then indeed did not suffer from this problem. At this momentheadversion ofdatahub-ingestionimage hasopensslversion3.0.11installed andsnowflake-connector-pythonversion3.9.1which means it does not suffer from this problem. Nevertheless when installingacryl-datahubpip package withsnowflakesupport it might happen that version older than3.4.0of thesnowflake-connector-pythonis installed - currentsetup.pyjust requires installed version to be different than2.8.2. This PR imposes additional requirement onpipto make suresnowflake-connector-pythonversion is newer or equal to3.4.0to avoid this problem (it did happen to me when working withacryl-datahubpip package recently).