Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connections) Add Connection entity type and graphql endpoints #10550

Merged
merged 2 commits into from
May 20, 2024
Merged

feat(connections) Add Connection entity type and graphql endpoints #10550

merged 2 commits into from
May 20, 2024

Conversation

chriscollins3456
Copy link
Collaborator

This PR adds a new connections entity type as well as some graphql endpoint that can interact with this connections entity.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels May 20, 2024
shirshanka
shirshanka approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label May 20, 2024
@shirshanka shirshanka merged commit 1240e03 into master May 20, 2024
64 of 65 checks passed
@shirshanka shirshanka deleted the cc--connections-entities branch May 20, 2024 22:56
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@chriscollins3456 @sleeperdeep
feat(connections): add connection entity type and graphql endpoints (d…
5e3ee04 
…atahub-project#10550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscollins3456 @shirshanka