Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/mode): Adding Dashboards into containers #10563

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(ingest/mode): Adding Dashboards into containers #10563

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c4084f
Adding Dashboards into collections
treff7es May 21, 2024
d1fde1e
Update golden files
treff7es May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
from datahub.configuration.common import AllowDenyPattern, ConfigModel
from datahub.configuration.source_common import DatasetLineageProviderConfigBase
from datahub.emitter.mcp import MetadataChangeProposalWrapper
from datahub.emitter.mcp_builder import ContainerKey, gen_containers
from datahub.emitter.mcp_builder import (
ContainerKey,
add_dataset_to_container,
gen_containers,
)
from datahub.ingestion.api.common import PipelineContext
from datahub.ingestion.api.decorators import (
SourceCapability,
Expand Down Expand Up @@ -1438,6 +1442,7 @@ def construct_space_container(
def emit_dashboard_mces(self) -> Iterable[MetadataWorkUnit]:
for space_token, space_name in self.space_tokens.items():
yield from self.construct_space_container(space_token, space_name)
space_container_key = self.gen_space_key(space_token)

reports = self._get_reports(space_token)
for report in reports:
Expand All @@ -1464,6 +1469,10 @@ def emit_dashboard_mces(self) -> Iterable[MetadataWorkUnit]:
aspect=SubTypesClass(typeNames=[BIAssetSubTypes.MODE_REPORT]),
)
yield mcpw.as_workunit()
yield from add_dataset_to_container(
container_key=space_container_key,
dataset_urn=dashboard_snapshot_from_report.urn,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this saying dataset_urn= is super confusing

)
yield browse_mcpw.as_workunit()

usage_statistics = DashboardUsageStatisticsClass(
Expand Down
Loading