From 90e0286de5d3e6e63c3953975988744637be70f5 Mon Sep 17 00:00:00 2001
From: mayurinehate <mayuri.nehate@gslab.com>
Date: Wed, 19 Oct 2022 11:34:01 +0530
Subject: [PATCH 1/2] fix(ingest): remove backticks from table name when
creating urn
---
.../src/datahub/ingestion/source/tableau_common.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
index d93320dd664e7..aa7db2a281fbc 100644
--- a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
+++ b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
@@ -467,7 +467,10 @@ def get_fully_qualified_table_name(
fully_qualified_table_name = fully_qualified_table_name.lower()
# strip double quotes and escaped double quotes
fully_qualified_table_name = (
- fully_qualified_table_name.replace('\\"', "").replace('"', "").replace("\\", "")
+ fully_qualified_table_name.replace('\\"', "")
+ .replace('"', "")
+ .replace("\\", "")
+ .replace("`", "")
)
if platform in ("athena", "hive", "mysql"):
From 89d53a1f482b95a67c6a801d30bf780df3852c44 Mon Sep 17 00:00:00 2001
From: mayurinehate <mayuri.nehate@gslab.com>
Date: Wed, 19 Oct 2022 11:41:18 +0530
Subject: [PATCH 2/2] update comment
---
.../src/datahub/ingestion/source/tableau_common.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
index aa7db2a281fbc..74e9759e97c4f 100644
--- a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
+++ b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
@@ -465,7 +465,7 @@ def get_fully_qualified_table_name(
# do some final adjustments on the fully qualified table name to help them line up with source systems:
# lowercase it
fully_qualified_table_name = fully_qualified_table_name.lower()
- # strip double quotes and escaped double quotes
+ # strip double quotes, escaped double quotes and backticks
fully_qualified_table_name = (
fully_qualified_table_name.replace('\\"', "")
.replace('"', "")