From 7ac27880ee078d9e417443b3d33a5951208babab Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Tue, 27 Dec 2022 21:52:59 +0530 Subject: [PATCH] refactor(smoke): use env variables --- smoke-test/tests/cypress/cypress/integration/login/login.js | 4 ++-- smoke-test/tests/utils.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/smoke-test/tests/cypress/cypress/integration/login/login.js b/smoke-test/tests/cypress/cypress/integration/login/login.js index 2c85ab4a77cc45..f86741b5afe010 100644 --- a/smoke-test/tests/cypress/cypress/integration/login/login.js +++ b/smoke-test/tests/cypress/cypress/integration/login/login.js @@ -1,8 +1,8 @@ describe('login', () => { it('logs in', () => { cy.visit('/'); - cy.get('input[data-testid=username]').type('datahub'); - cy.get('input[data-testid=password]').type('datahub'); + cy.get('input[data-testid=username]').type(Cypress.env('ADMIN_USERNAME')); + cy.get('input[data-testid=password]').type(Cypress.env('ADMIN_PASSWORD')); cy.contains('Sign In').click(); cy.contains('Welcome back, DataHub'); }); diff --git a/smoke-test/tests/utils.py b/smoke-test/tests/utils.py index 98ba2e9ce68f45..cd8208a42724bf 100644 --- a/smoke-test/tests/utils.py +++ b/smoke-test/tests/utils.py @@ -27,7 +27,7 @@ def get_frontend_session(): def get_admin_username() -> str: - return os.getenv("ADMIN_USERNAME", "datahub") + return get_admin_credentials()[0] def get_admin_credentials():