Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): use hive pure_sasl variant #8570

Merged
merged 3 commits into from
Aug 9, 2023
Merged

fix(ingest): use hive pure_sasl variant #8570

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cff546d
fix(ingest): use hive pure_sasl variant
hsheth2 Aug 3, 2023
32a862c
also fix https://github.com/dropbox/PyHive/issues/417
hsheth2 Aug 3, 2023
3aa4dd1
use non-rc
hsheth2 Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions metadata-ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,20 @@ def get_long_description():
"trino[sqlalchemy]>=0.308, !=0.317",
}

pyhive_common = {
# Acryl Data maintains a fork of PyHive
# - 0.6.11 adds support for table comments and column comments,
# and also releases HTTP and HTTPS transport schemes
# - 0.6.12 adds support for Spark Thrift Server
# - 0.6.13 adds a small fix for Databricks
# - 0.6.14 uses pure-sasl instead of sasl so it builds on Python 3.11
"acryl-pyhive[hive_pure_sasl]==0.6.14",
# As per https://github.com/datahub-project/datahub/issues/8405
# and https://github.com/dropbox/PyHive/issues/417, new versions
# of thrift break PyHive's hive+http transport.
"thrift<0.14.0",
}

microsoft_common = {"msal==1.22.0"}

iceberg_common = {
Expand Down Expand Up @@ -318,12 +332,8 @@ def get_long_description():
"hdbcli>=2.11.20; platform_machine != 'aarch64' and platform_machine != 'arm64'",
},
"hive": sql_common
| pyhive_common
| {
# Acryl Data maintains a fork of PyHive
# - 0.6.11 adds support for table comments and column comments,
# and also releases HTTP and HTTPS transport schemes
# - 0.6.12 adds support for Spark Thrift Server
"acryl-pyhive[hive]>=0.6.13",
"databricks-dbapi",
# Due to https://github.com/great-expectations/great_expectations/issues/6146,
# we cannot allow 0.15.{23-26}. This was fixed in 0.15.27 by
Expand All @@ -348,9 +358,10 @@ def get_long_description():
"okta": {"okta~=1.7.0"},
"oracle": sql_common | {"cx_Oracle"},
"postgres": sql_common | {"psycopg2-binary", "GeoAlchemy2"},
"presto": sql_common | trino | {"acryl-pyhive[hive]>=0.6.12"},
"presto": sql_common | pyhive_common | trino,
"presto-on-hive": sql_common
| {"psycopg2-binary", "acryl-pyhive[hive]>=0.6.12", "pymysql>=1.0.2"},
| pyhive_common
| {"psycopg2-binary", "pymysql>=1.0.2"},
"pulsar": {"requests"},
"redash": {"redash-toolbelt", "sql-metadata"} | sqllineage_lib,
"redshift": sql_common | redshift_common | usage_common | {"redshift-connector"},
Expand Down
Loading