Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingestion/mongodb): Add platform_instance to mongodb #8663

Merged
merged 3 commits into from
Oct 26, 2023
Merged

refactor(ingestion/mongodb): Add platform_instance to mongodb #8663

merged 3 commits into from
Oct 26, 2023

Conversation

nicholas-fwang
Copy link
Contributor

@nicholas-fwang nicholas-fwang commented Aug 18, 2023 •
edited
Loading

Add platform_instance field to mongodb source.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 18, 2023
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Aug 21, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 23, 2023

@nicholas-fwang sorry about the delay in reviewing this one!

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 23, 2023
@hsheth2 hsheth2 merged commit 8522679 into datahub-project:master Oct 26, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-fwang @hsheth2 @maggiehays