Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-setup): quote database name #9169

Merged

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Nov 2, 2023

Some database names are only accepted if quoted. See Schema Object Names in the MySQL documentation for background. This changes the init SQL file to always quote the database name.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 2, 2023
@darnaut darnaut merged commit ddb4e1b into datahub-project:master Nov 3, 2023
34 checks passed
@darnaut darnaut deleted the mysql-setup-backtick-database-name branch November 3, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants