Skip to content

Conversation

@guzman-raphael
Copy link
Collaborator

@guzman-raphael guzman-raphael commented Oct 30, 2020

Fix #110

  • Adds unique option for primary and nonprimary foreign key attributes
  • Adds nullable option for nonprimary foreign key attributes

For instance, the syntax to properly set within the Table definition could be:

%{
# ActiveSession
-> [unique] Lab.Subject
---
(session_rig_class, session_rig_id) -> [nullable, unique] Lab.Rig(rig_manufacturer, rig_model)
%}

Note: describe currently does not support showing set indices and will continue to not show with this update. Will file a separate issue to track it (#305).

@ixcat
Copy link

ixcat commented Oct 30, 2020

seems good to me but not merging until more eyes 👀

@eywalker eywalker merged commit 508f0d1 into external-storage Nov 2, 2020
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that the only possible properties of dependencies are NULLABLE and UNIQUE and all misspellings are rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants