Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-13044: Increase MAX_ACCEPTABLE_MEASUREMENT_ERROR in StageTimeMeasurementTest #1588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jkni
Copy link

@jkni jkni commented Feb 20, 2025

What is the issue

In CI, occasionally see MAX_ACCEPTABLE_MEASUREMENT_ERROR exceeded by 1 to 2% of TASK_DURATION_NANOS. This causes flaky test failures.

What does this PR fix and why was it fixed

Increases the maximum acceptable error from 10% to 15%. I'll multiplex with this parameter.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jkni
Copy link
Author

jkni commented Feb 20, 2025

Multiplexing showed even more flakiness; I'll investigate further and update the PR.

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1588 rejected by Butler


1 new test failure(s) in 4 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔵🔵🔴 🔵🔵🔵🔵🔵🔵🔵

Found 8 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants