Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivacyInfo.xcprivacy #325

Closed
wants to merge 2 commits into from
Closed

Add PrivacyInfo.xcprivacy #325

wants to merge 2 commits into from

Conversation

dp221125
Copy link

@dp221125 dp221125 commented Mar 15, 2024

This PR adds a privacy manfiest (PrivacyInfo.xcprivacy), Apple has not been mentioned here, but this SDK is using the User Defaults API

However, choosing a reason for NSPrivacyAccessedAPITypeReasons can be somewhat confusing. It would be helpful if you could check if there are any NSPrivacyAccessedAPITypeReasons that you think are more suitable.

resolve #319

@dp221125
Copy link
Author

I just added a resource, but I don't understand why the tests are failing.

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
Copy link

@manahilov manahilov Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the tracking as well similar to.

       <key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably worth having all of the compatible keys present and specify no for tracking, empty array for tracking domains, and fill out the key for privacy label.

If I'm not mistaken, if a cert pin fails, the SDK will transmit aka "collect" data and send off device. Being clear and transparent would include that information. It would probably qualify as App Privacy Label "other data".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reflected on the suggestion. Thank you. (c85ade9)

@uroboro
Copy link
Contributor

uroboro commented Mar 20, 2024

Thank you for your contribution. I went with a slightly different approach in #326 and fixed the issue with the pipelines

@uroboro uroboro closed this Mar 20, 2024
@claypark12
Copy link

Thank you for your quick feedback. when will the version update proceed?

@uroboro
Copy link
Contributor

uroboro commented Mar 23, 2024

3.0.4 has been released for SPM and CocoaPods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple's update to their API policy - Required Reason in Privacy manifest
5 participants