Parse regular expression filter before storing to provenance graph

[oltionchampari]

Closes #306

Summary

• The cause of the issue was applying JSON.stringify() to a RegExp object returns always {}

JSON.stringify({regexp: /^B/gm});
// result: "{\"regexp\":{}}"

which resulted in the provenance graph not properly storing the filter value.

• Added a between step that:
  • transforms the regex filter to a string before storing it to the provenance graph
  • transforms it back to a regular expression when the replay happens.

[thinkh]

@oltionchampari I improved some function and variable names and added more comments.

In my tests it works when I applying a regexp filter in the string column, but it does not work when I add another filter in the categorical column.

cmds.ts:390 Uncaught (in promise) TypeError: Cannot read property 'isRegExp' of null
    at restoreRegExp (cmds.ts:390)
    at ActionNode.<anonymous> (cmds.ts:201)
    at Generator.next (<anonymous>)
    at fulfilled (tslib.es6.js:62)

Please fix this behavior and test it more deeply in combination with other filters and jumping back and forth in the provenance graph.

[thinkh]

See previous comment.

[oltionchampari]

See previous comment.

Thanks for the feedback and the further optimizations you made!

The problem above was that i wasn't checking for null values.
After extensive testing everything seems to be working as expected.

[thinkh]

@oltionchampari I still get an error when I play around with different filters.

Please test the following provenance graph:

Temporary Session 266.json.txt

[oltionchampari]

@oltionchampari I still get an error when I play around with different filters.

Please test the following provenance graph:

Temporary Session 266.json.txt

@thinkh Cant reproduce it. Maybe you don't have the latest branch .

[thinkh]

Yes, indeed it works!

[thinkh]

Thanks! Works and looks good.

[thinkh]

@oltionchampari Could please try one more time, if the provenance graph with a value: {} in the action will not break anymore.

[oltionchampari]

@oltionchampari Could please try one more time, if the provenance graph with a value: {} in the action will not break anymore.

The current solution also works for filter value: {}. The filter value: {} is set and the rest of the prov graph steps continue running.