Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overflow: hidden to fix download drop down #321

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Mar 16, 2020

Closes #320

Summary

The overflow hidden is not necessary anymore and cuts off the drop down of the download button.

grafik

It also works with closed side panel:

grafik

Tested in Firefox 74 and Chrome 80.

The overflow hidden is not necessary anymore and cuts off the drop down of the download button.
@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Mar 16, 2020
@thinkh thinkh requested a review from oltionchampari March 16, 2020 11:52
@thinkh thinkh requested a review from lehnerchristian as a code owner March 16, 2020 11:52
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected now.

@oltionchampari oltionchampari merged commit 80eb0be into develop Mar 16, 2020
@oltionchampari oltionchampari deleted the thinkh/fix-download-dropdown branch March 16, 2020 12:01
@dvvanessastoiber dvvanessastoiber mentioned this pull request Mar 18, 2020
29 tasks
@ghost ghost mentioned this pull request Mar 19, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The side panel has overflow: hidden which hides the download button dropdown.
2 participants