-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group height in overview mode #366
Fix group height in overview mode #366
Conversation
Closes #365 Previously, the group height is set as hard-coded values and ignores the LineUp/Taggle default config values. This refactoring uses the taggle options (LineUp default config + ARankingView custom options). The event `LineUpPanelActions.EVENT_RULE_CHANGED` was removed and replaced with the `LineUpPanelActions.EVENT_TOGGLE_OVERVIEW` which simply returns a boolean. Afterwards the space-filling rule is only instanciated and used in ARankingView.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix works for me as expected and the source code looks good. 👍
This fix made another issue more obvious though.
The bars of the groups appear and disappear when switching back and forth to overview mode.
This should be addressed in another issue though since it occurs also for the lineupjs4 branch. It is harder to spot because of the bars changing their height.
@thinkh If you agree to address this in a new issue we can merge this branch.
Thanks for testing and well spotted! Can you please extract the bug you've found to a new issue? We can adress it in a different PR. You can go ahead and merge this PR. |
Okay, will do. |
Fixes #365
Summary
Uses the same group height in overview mode.
Implementation
Previously, the group height is set as hard-coded values and ignores the LineUp/Taggle default config values.
This refactoring uses the taggle options (LineUp default config + ARankingView custom options).
The event
LineUpPanelActions.EVENT_RULE_CHANGED
was removed and replaced with theLineUpPanelActions.EVENT_TOGGLE_OVERVIEW
which simply returns a boolean. Afterwards the space-filling rule is only instanciated and used in ARankingView.You can change the heights by defining the respective LineUp/Taggle config values in the
customOptions
ofARankingView
.