Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable propagation of aggregation state for child groups in ARankingView #387

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jul 7, 2020

Closes #386

Requires lineupjs/lineupjs#376

Summary

Before

ordino-propagate-grouping

After

ordino-disable-propagate-grouping

@anita-steiner + @dg-datavisyn This PR changes the current default behavior in ARankingView. If this a problem for some apps I can integrate the change directly in Ordino (and not here in tdp_core).

@thinkh thinkh requested review from a user and dg-datavisyn July 7, 2020 11:23
@thinkh thinkh requested a review from lehnerchristian as a code owner July 7, 2020 11:23
@thinkh thinkh self-assigned this Jul 7, 2020
@thinkh thinkh requested a review from puehringer July 7, 2020 13:56
@thinkh thinkh merged commit deb6208 into develop Jul 14, 2020
@thinkh thinkh deleted the thinkh/386_disable-propagate-aggregation-state branch July 14, 2020 10:29
@thinkh thinkh mentioned this pull request Jul 30, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants