Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed getValue to getExportValue in Excel export #420

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Changed getValue to getExportValue in Excel export #420

merged 1 commit into from
Oct 5, 2020

Conversation

puehringer
Copy link
Contributor

Closes #419

thinkh
thinkh approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the export with different rankings and score columns and it works for me.

@thinkh thinkh merged commit ef72b4d into develop Oct 5, 2020
@thinkh thinkh deleted the mp/419_export_value_lineup branch October 5, 2020 09:26
@thinkh thinkh added release: patch PR merge results in a new patch version type: refactor Refactor the current implementation labels Oct 5, 2020
@thinkh thinkh linked an issue Oct 12, 2020 that may be closed by this pull request
Changed Excel export to use getExportValue from LineUp #419
Closed
@dvvanessastoiber dvvanessastoiber mentioned this pull request Jan 27, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@lehnerchristian lehnerchristian lehnerchristian approved these changes

Assignees

@lehnerchristian lehnerchristian

@thinkh thinkh

Labels
release: patch PR merge results in a new patch version type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changed Excel export to use getExportValue from LineUp
3 participants
@puehringer @lehnerchristian @thinkh