Introduce client config #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
thinkh
requested changes
Dec 28, 2020
src/ATDPApplication.ts
Outdated
Comment on lines
145
to
146
| // TODO: Do you want to print an error here, or should it fail silently? | ||
| console.error('Error parsing clientConfig.json', e); |
There was a problem hiding this comment.
I would log an error and add empty clientConfigs.json to every existing apps. New apps should have an empty clientConfig.json by default.
We should probably remove the TODO marker before merging the PR.
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
thinkh
approved these changes
Jan 4, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs phovea/generator-phovea#449
Summary
https://docs.google.com/presentation/d/1k36d_CGs5euOdk73AUNC54mWKzztud17ltzkxhM-KU0/edit#