Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema (#60): pattern constraint for string types #168

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

mhuang74
Copy link
Contributor

@mhuang74 mhuang74 commented Feb 15, 2022

Schema (#60): pattern constraint for string types

Overall, probably only want to generate pattern constraint for columns that have clear structure to their value, but too large to generate enum constraint for. This works in general, but lacks the smarts to recognize common formats, e.g. email address or date timestamp.

  • choose columns to generate pattern constraint via --pattern-columns option
  • only generate pattern constraint for String types without enum constraint
  • updated integration test for schema and validate

@mhuang74 mhuang74 mentioned this pull request Feb 15, 2022
@jqnatividad jqnatividad merged commit 3b5ab1a into dathere:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants