Allow children in mobile nav #1086
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
|
@homostellaris is attempting to deploy a commit to the Datopian Team on Vercel. A member of the Team first needs to authorize it. |
|
Accidentally added some reformatting there, will tidy that up shortly |
homostellaris
force-pushed
the
allow-children-in-mobile-nav
branch
from
3334166
to
cb5bef9
Compare
|
Diff is cleaned up now, looks like I need authorization to pass some checks though? |
|
@Gutts-n sorry to @ you but any idea what I can do to get this merged? Myself and many others would love this to enable mobile site-wide table of contents for Flowershow. |
|
Hello @homostellaris you could request @olayway to make the CR, and your PR doesn't have a changeset, you need to run
|
Adds some finishing touches to @olayway's work to allow the mobile nav to render arbitrary children which can be useful for things like site-wide navigation. Also adds some stories to demonstrate the new functionality and migrates to the Storybook NextJs 'framework' which allows the Nav component to be rendered in a story with all the routing automatically stubbed and taken care of.
homostellaris
force-pushed
the
allow-children-in-mobile-nav
branch
from
cb5bef9
to
7b38ce1
Compare
|
Any way to progress this? Totally understand if this isn't a priority but just to provide honest feedback, I'll have to eventually migrate away from Flowershow if the open source community isn't active 🙏 |
Adds some finishing touches to @olayway's work to
allow the mobile nav to render arbitrary children
which can be useful for things like site-wide
navigation.
Also adds some stories to demonstrate the new
functionality and migrates to the Storybook NextJs 'framework' which allows the Nav component to be
rendered in a story with all the routing
automatically stubbed and taken care of.
Screen.Recording.2024-02-02.at.17.23.55.mov