From 804920f2820e9b88d10b149d823f849fa6c065a9 Mon Sep 17 00:00:00 2001 From: Jim Kring Date: Mon, 11 Nov 2024 09:23:02 -0800 Subject: [PATCH] Fixes "Coverage Trend Indicator" for pull requests with slash ('/') in the name Artifacts cannot have forward slashes ('/') in the name, which causes dependabot tests to fail and could also impact gitflow and other systems that use slashes in the branch names. --- README.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 770167f..bceff3f 100644 --- a/README.md +++ b/README.md @@ -168,9 +168,11 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - branch: - - ${{ github.head_ref }} - - "main" + include: + - branch: main + artifact: main + - branch: ${{ github.head_ref }} + artifact: pull-request permissions: # Required to checkout the code @@ -193,7 +195,7 @@ jobs: - name: "Upload Coverage" uses: actions/upload-artifact@v4 with: - name: coverage-${{ matrix.branch }} + name: coverage-${{ matrix.artifact }} path: coverage report-coverage: @@ -203,7 +205,7 @@ jobs: - name: "Download Coverage Artifacts" uses: actions/download-artifact@v4 with: - name: coverage-${{ github.head_ref }} + name: coverage-pull-request path: coverage - uses: actions/download-artifact@v4 with: