From 4fa974c787247eaf222dc3c8529aef0b93be1419 Mon Sep 17 00:00:00 2001 From: seniorapple Date: Mon, 25 Jul 2016 09:09:16 +0100 Subject: [PATCH] Update player when width or height changes Fixes https://github.com/CookPete/react-player/issues/84 --- src/ReactPlayer.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/ReactPlayer.js b/src/ReactPlayer.js index 340fc8f..6b19183 100644 --- a/src/ReactPlayer.js +++ b/src/ReactPlayer.js @@ -21,7 +21,9 @@ export default class ReactPlayer extends Component { return ( this.props.url !== nextProps.url || this.props.playing !== nextProps.playing || - this.props.volume !== nextProps.volume + this.props.volume !== nextProps.volume || + this.props.height !== nextProps.height || + this.props.width !== nextProps.width ) } seekTo = fraction => { @@ -32,17 +34,10 @@ export default class ReactPlayer extends Component { } progress = () => { if (this.props.url && this.refs.player) { - let progress = {} const loaded = this.refs.player.getFractionLoaded() const played = this.refs.player.getFractionPlayed() - if (loaded !== null && loaded !== this.prevLoaded) { - progress.loaded = this.prevLoaded = loaded - } - if (played !== null && played !== this.prevPlayed && this.props.playing) { - progress.played = this.prevPlayed = played - } - if (progress.loaded || progress.played) { - this.props.onProgress(progress) + if (loaded || played) { + this.props.onProgress({ loaded, played }) } } this.progressTimeout = setTimeout(this.progress, this.props.progressFrequency)