Headers are shown multiple times

[long1eu]

I switched to this wonderful lib. I spend whole day reading docs. But still I have this issue. Headers are displays above every item.

As always the code is here:
https://github.com/thelong1EU/FlipViewDemo

[davideas]

@thelong1EU, UserHeader must be the same instance for each section, so you should NOT create new header object for each sectionable item in your use case.

Thanks, I've updated the Wiki with better explanation.

[long1eu]

I see. I thought that the equals method deals with it.

…

On May 7, 2017 12:18 AM, "Davide Steduto" ***@***.***> wrote: @thelong1EU <https://github.com/thelong1EU>, UserHeader must be the *same* instance for each section, so you should NOT create new header object for each sectionable in your use case. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#355 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI2nVpSuc3yP3QnKFXBKgpD7IUQD89Hpks5r3OOHgaJpZM4NS6Ko> .

[long1eu]

I changed it in the mock app and it works. But on my real app it doesn't. I get the same result. I think I found the reason. In the FlexibleAdapter there is the method showAllHeadersWithReset(). Here you check if the headers are the same instance. Why not try equals? My Item and Header are Parcelable. So when I pass them in an Intent they are recreated and are not the same instance anymore.

Should I make a pull request?

private void showAllHeadersWithReset(boolean init) {
        int position = 0;
        IHeader sameHeader = null;
        while (position < getItemCount() - mScrollableFooters.size()) {
            T item = mItems.get(position);
            // Reset hidden status! Necessary after the filter and the update
            IHeader header = getHeaderOf(item);

            //should be !header.equals(sameHeader)
            if (header != sameHeader && header != null && !isExpandable((T) header)) {
                sameHeader = header;
                header.setHidden(true);
            }
            if (showHeaderOf(position, item, init))
                position++; //It's the same element, skip it
            position++;
        }
        headersShown = true;
    }

Where are you from? I really want to give you a beer.

[davideas]

Hi @thelong1EU, I didn't think about Parcelable, sometimes we write a feature without seeing all the user points of views for development, some can be missed. The improvement can be done.

I'm Italian living in Brussels. for the beer I will check about donations, because you are not the first, neither second that would like to, I appreciate it :-D

[long1eu]

Added fix to #357, so I'm closing this.
Thanks again.