Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vue): optimize reactivity handling and reduce bundle size #929

Merged
merged 3 commits into from
Jul 12, 2024
Merged

refactor(vue): optimize reactivity handling and reduce bundle size #929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90b53eb
perf(vue): use shallowRef instead of ref
negezor Jul 3, 2024
19a52e0
perf(vue): use simple variables instead of ref
negezor Jul 3, 2024
4b3d40c
refactor(vue): use MaybeRef type
negezor Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions packages/embla-carousel-vue/src/components/emblaCarouselVue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { Ref, ref, isRef, watch, onMounted, onBeforeUnmount } from 'vue'
import {
Ref,
MaybeRef,
isRef,
watch,
onMounted,
onBeforeUnmount,
shallowRef
} from 'vue'
import {
areOptionsEqual,
arePluginsEqual,
Expand All @@ -16,45 +24,49 @@ export type EmblaCarouselVueType = [
]

function emblaCarouselVue(
options: EmblaOptionsType | Ref<EmblaOptionsType> = {},
plugins: EmblaPluginType[] | Ref<EmblaPluginType[]> = []
options: MaybeRef<EmblaOptionsType> = {},
plugins: MaybeRef<EmblaPluginType[]> = []
): EmblaCarouselVueType {
const storedOptions = ref(isRef(options) ? options.value : options)
const storedPlugins = ref(isRef(plugins) ? plugins.value : plugins)
const emblaNode = ref<HTMLElement>()
const emblaApi = ref<EmblaCarouselType>()
const isRefOptions = isRef(options)
const isRefPlugins = isRef(plugins)

let storedOptions = isRefOptions ? options.value : options
davidjerleke marked this conversation as resolved.
Show resolved Hide resolved
let storedPlugins = isRefPlugins ? plugins.value : plugins

const emblaNode = shallowRef<HTMLElement>()
const emblaApi = shallowRef<EmblaCarouselType>()

function reInit() {
if (!emblaApi.value) return
emblaApi.value.reInit(storedOptions.value, storedPlugins.value)
emblaApi.value.reInit(storedOptions, storedPlugins)
}

onMounted(() => {
if (!canUseDOM() || !emblaNode.value) return
EmblaCarousel.globalOptions = emblaCarouselVue.globalOptions
emblaApi.value = EmblaCarousel(
emblaNode.value,
storedOptions.value,
storedPlugins.value
storedOptions,
storedPlugins
)
})

onBeforeUnmount(() => {
if (emblaApi.value) emblaApi.value.destroy()
})

if (isRef(options)) {
if (isRefOptions) {
watch(options, (newOptions) => {
if (areOptionsEqual(storedOptions.value, newOptions)) return
storedOptions.value = newOptions
if (areOptionsEqual(storedOptions, newOptions)) return
storedOptions = newOptions
reInit()
})
}

if (isRef(plugins)) {
if (isRefPlugins) {
watch(plugins, (newPlugins) => {
if (arePluginsEqual(storedPlugins.value, newPlugins)) return
storedPlugins.value = newPlugins
if (arePluginsEqual(storedPlugins, newPlugins)) return
storedPlugins = newPlugins
reInit()
})
}
Expand Down