From 00051072445d4bf843c513e600b0a32f4b7b36ab Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 06:17:33 +1100
Subject: [PATCH 1/8] Click photo to toggle

---
 Desktop/Windows/ApplicantDetailsWindow.xaml    | 2 +-
 Desktop/Windows/ApplicantDetailsWindow.xaml.cs | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml b/Desktop/Windows/ApplicantDetailsWindow.xaml
index 7fab2dc1..a9cb9b85 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml
@@ -161,6 +161,6 @@
                 </TextBlock>
             </CheckBox>
         </Grid>
-        <Image Grid.Column="1" Grid.RowSpan="3" x:Name="ImageControl"/>
+        <Image Grid.Column="1" Grid.RowSpan="3" x:Name="ImageControl" MouseLeftButtonDown="ImageControl_MouseLeftButtonDown"/>
     </Grid>
 </Window>
diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
index c5a516e1..688d69e5 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
@@ -79,5 +79,13 @@ private void Window_KeyDown(object sender, System.Windows.Input.KeyEventArgs e)
                 Close();
             }
         }
+
+        private void ImageControl_MouseLeftButtonDown(object sender, MouseButtonEventArgs e)
+        {
+            if (DataContext is ApplicantForRole afr)
+            {
+                afr.IsSelected = !afr.IsSelected;
+            }
+        }
     }
 }

From 880cb63ac1d934f7e427f72432d1c4faee242a0a Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 06:36:19 +1100
Subject: [PATCH 2/8] Grey image when not selected

---
 Desktop/Windows/ApplicantDetailsWindow.xaml    |  8 +++++++-
 Desktop/Windows/ApplicantDetailsWindow.xaml.cs | 16 +++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml b/Desktop/Windows/ApplicantDetailsWindow.xaml
index a9cb9b85..2deae823 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml
@@ -19,6 +19,11 @@
         </cv:MultiConverter>
         <cv:HideIfEmpty x:Key="hideIfEmpty"/>
         <cv:AbilityMarkFormatter x:Key="abilityMarkFormatter"/>
+        <cv:MultiConverter x:Key="showIfFalse">
+            <cv:InvertBoolean/>
+            <BooleanToVisibilityConverter/>
+        </cv:MultiConverter>
+        <BooleanToVisibilityConverter x:Key="showIfTrue"/>
     </Window.Resources>
     <Grid>
         <Grid.ColumnDefinitions>
@@ -161,6 +166,7 @@
                 </TextBlock>
             </CheckBox>
         </Grid>
-        <Image Grid.Column="1" Grid.RowSpan="3" x:Name="ImageControl" MouseLeftButtonDown="ImageControl_MouseLeftButtonDown"/>
+        <Image Grid.Column="1" Grid.RowSpan="3" x:Name="ImageControl" MouseLeftButtonDown="ImageControl_MouseLeftButtonDown" Visibility="{Binding IsSelected, Converter={StaticResource showIfTrue}}"/>
+        <Image Grid.Column="1" Grid.RowSpan="3" x:Name="ImageControlGrey" MouseLeftButtonDown="ImageControl_MouseLeftButtonDown" Visibility="{Binding IsSelected, Converter={StaticResource showIfFalse}}"/>
     </Grid>
 </Window>
diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
index 688d69e5..409c1977 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
@@ -10,6 +10,8 @@
 using System.Windows;
 using System.Windows.Data;
 using System.Windows.Input;
+using System.Windows.Media;
+using System.Windows.Media.Imaging;
 
 namespace Carmen.Desktop.Windows
 {
@@ -59,9 +61,21 @@ private void Window_Closed(object sender, EventArgs e)
         private async void Window_Loaded(object sender, RoutedEventArgs e)
         {
             if (applicant.PhotoImageId is int photo_id)
-                ImageControl.Source = await ApplicantImage.CachedImage(applicant.PhotoImageId.Value, applicant.ShowRoot, LoadApplicantImage);
+            {
+                var source = await ApplicantImage.CachedImage(applicant.PhotoImageId.Value, applicant.ShowRoot, LoadApplicantImage);
+                ImageControl.Source = source;
+                var grey = new FormatConvertedBitmap();
+                grey.BeginInit();
+                grey.Source = (BitmapSource)source;
+                grey.DestinationFormat = PixelFormats.Gray32Float;
+                grey.EndInit();
+                ImageControlGrey.Source = grey;
+            }
             else
+            {
                 ImageControl.Source = null;
+                ImageControlGrey.Source = null;
+            }
         }
 
         /// <summary>Loads the applicant's photo in a dedicated db context to avoid concurrency issues</summary>

From 609bfa402f0198b2c935c20f87aa45978bc9fbc6 Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 06:53:06 +1100
Subject: [PATCH 3/8] Refactor ApplicantDetailsWindow to take interface

---
 Desktop/ViewModels/ApplicantForRole.cs        |  4 +++-
 Desktop/ViewModels/ISelectableApplicant.cs    | 23 +++++++++++++++++++
 Desktop/Windows/ApplicantDetailsWindow.xaml   |  5 +---
 .../Windows/ApplicantDetailsWindow.xaml.cs    | 10 ++++----
 4 files changed, 32 insertions(+), 10 deletions(-)
 create mode 100644 Desktop/ViewModels/ISelectableApplicant.cs

diff --git a/Desktop/ViewModels/ApplicantForRole.cs b/Desktop/ViewModels/ApplicantForRole.cs
index a491afb1..406eecd1 100644
--- a/Desktop/ViewModels/ApplicantForRole.cs
+++ b/Desktop/ViewModels/ApplicantForRole.cs
@@ -14,7 +14,7 @@
 
 namespace Carmen.Desktop.ViewModels
 {
-    public class ApplicantForRole : INotifyPropertyChanged
+    public class ApplicantForRole : ISelectableApplicant, INotifyPropertyChanged
     {
         public Applicant Applicant { get; init; }
         public Criteria[] PrimaryCriterias { get; init; }
@@ -97,6 +97,8 @@ public IEnumerable<string> UnavailabilityReasons
 
         public string CommaSeparatedIneligibilityReason => string.Join(", ", IneligibilityReasons);
 
+        public string SelectionText => $"Allocate {RoleName} to {FirstName}";
+
         public ApplicantForRole(IAllocationEngine engine, Applicant applicant, Role role, Criteria[] primary_criterias)
         {
             this.Applicant = applicant;
diff --git a/Desktop/ViewModels/ISelectableApplicant.cs b/Desktop/ViewModels/ISelectableApplicant.cs
new file mode 100644
index 00000000..096657f7
--- /dev/null
+++ b/Desktop/ViewModels/ISelectableApplicant.cs
@@ -0,0 +1,23 @@
+using Carmen.ShowModel.Applicants;
+using Carmen.ShowModel.Criterias;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Carmen.Desktop.ViewModels
+{
+    public interface ISelectableApplicant
+    {
+        Applicant Applicant { get; }
+        Criteria[] PrimaryCriterias { get; }
+        bool IsSelected { get; set; }
+        string FirstName { get; }
+        string LastName { get; }
+        string SelectionText { get; }
+        IEnumerable<string> ExistingRoles { get; }
+        IEnumerable<string> UnavailabilityReasons { get; }
+        IEnumerable<string> IneligibilityReasons { get; }
+    }
+}
diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml b/Desktop/Windows/ApplicantDetailsWindow.xaml
index 2deae823..a1c86395 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml
@@ -159,10 +159,7 @@
         <Grid Grid.Row="2" Margin="5">
             <CheckBox IsChecked="{Binding IsSelected}">
                 <TextBlock>
-                    <Run Text="Allocate"/>
-                    <Run Text="{Binding RoleName, Mode=OneWay}"/>
-                    <Run Text="to"/>
-                    <Run Text="{Binding FirstName, Mode=OneWay}"/>
+                    <Run Text="{Binding SelectionText, Mode=OneWay}"/>
                 </TextBlock>
             </CheckBox>
         </Grid>
diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
index 409c1977..ff3b6b88 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml.cs
@@ -28,17 +28,17 @@ public partial class ApplicantDetailsWindow : Window
 
         public bool IsClosed { get; private set; } = false;
 
-        public ApplicantDetailsWindow(ShowConnection connection, Criteria[] criterias, IAuditionEngine audition_engine, ApplicantForRole applicant_for_role)
+        public ApplicantDetailsWindow(ShowConnection connection, Criteria[] criterias, IAuditionEngine audition_engine, ISelectableApplicant selectable_applicant)
         {
             this.connection = connection;
-            this.applicant = applicant_for_role.Applicant;
+            this.applicant = selectable_applicant.Applicant;
             Title = WindowTitleFor(applicant);
             InitializeComponent();
             criteriasViewSource = (CollectionViewSource)FindResource(nameof(criteriasViewSource));
             criteriasViewSource.Source = criterias;
             overallAbilityCalculator = (OverallAbilityCalculator)FindResource(nameof(overallAbilityCalculator));
             overallAbilityCalculator.AuditionEngine = audition_engine;
-            DataContext = applicant_for_role; // must be done after setting up overallAbilityCalculator
+            DataContext = selectable_applicant; // must be done after setting up overallAbilityCalculator
         }
 
         private static string WindowTitleFor(Applicant a)
@@ -96,9 +96,9 @@ private void Window_KeyDown(object sender, System.Windows.Input.KeyEventArgs e)
 
         private void ImageControl_MouseLeftButtonDown(object sender, MouseButtonEventArgs e)
         {
-            if (DataContext is ApplicantForRole afr)
+            if (DataContext is ISelectableApplicant sa)
             {
-                afr.IsSelected = !afr.IsSelected;
+                sa.IsSelected = !sa.IsSelected;
             }
         }
     }

From 703e4842b0fe4d356afc817cb005f4a2e54fadc2 Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 07:11:36 +1100
Subject: [PATCH 4/8] Change double click to show details

---
 Desktop/Pages/SelectCast.xaml    |  8 +++---
 Desktop/Pages/SelectCast.xaml.cs | 44 ++++++++++++++++++++++++--------
 2 files changed, 38 insertions(+), 14 deletions(-)

diff --git a/Desktop/Pages/SelectCast.xaml b/Desktop/Pages/SelectCast.xaml
index 75abe3f4..6e086233 100644
--- a/Desktop/Pages/SelectCast.xaml
+++ b/Desktop/Pages/SelectCast.xaml
@@ -251,7 +251,7 @@
                 </TextBlock>
             </Grid>
             <ListBox x:Name="selectedList" Grid.Column="0" Grid.Row="1" Grid.RowSpan="7"
-                     SelectionMode="Extended" MouseDoubleClick="selectedList_MouseDoubleClick"
+                     SelectionMode="Extended" MouseDoubleClick="List_MouseDoubleClick"
                      HorizontalContentAlignment="Stretch"
                      ItemsSource="{Binding Source={StaticResource selectedApplicantsViewSource}}">
                 <ListBox.ItemContainerStyle>
@@ -345,7 +345,7 @@
                 <TextBlock Grid.Column="2" Text="{Binding Source={StaticResource allApplicantsViewSource}, Path=Count}" Margin="10 0" FontSize="18" VerticalAlignment="Center"/>
             </Grid>
             <ListBox x:Name="availableList" Grid.Column="2" Grid.Row="1" Grid.RowSpan="7"
-                     SelectionMode="Extended" MouseDoubleClick="availableList_MouseDoubleClick"
+                     SelectionMode="Extended" MouseDoubleClick="List_MouseDoubleClick"
                      HorizontalContentAlignment="Stretch"
                      ItemsSource="{Binding Source={StaticResource allApplicantsViewSource}}">
                 <ListBox.ItemContainerStyle>
@@ -476,7 +476,7 @@
                 <Button DockPanel.Dock="Bottom" Height="30" Margin="0 5 0 0" Click="DeleteSameCastSet_Click"
                         Content="Delete selected set"/>
                 <ListBox x:Name="selectedSameCastSetList" 
-                     SelectionMode="Extended" MouseDoubleClick="selectedSameCastSetList_MouseDoubleClick"
+                     SelectionMode="Extended"
                      ItemsSource="{Binding ElementName=sameCastSetsList, Path=SelectedItem.Applicants}">
                     <ListBox.ItemContainerStyle>
                         <Style TargetType="{x:Type ListBoxItem}">
@@ -505,7 +505,7 @@
                        Text="Available applicants"
                        Visibility="{Binding ElementName=sameCastSetsList, Path=SelectedItem, Converter={StaticResource hideIfNull}}"/>
             <ListBox x:Name="availableSameCastSetList" Grid.Column="4" Grid.Row="2" Grid.RowSpan="7"
-                     SelectionMode="Extended" MouseDoubleClick="availableSameCastSetList_MouseDoubleClick"
+                     SelectionMode="Extended"
                      ItemsSource="{Binding Source={StaticResource allApplicantsViewSource}}"
                      Visibility="{Binding ElementName=sameCastSetsList, Path=SelectedItem, Converter={StaticResource hideIfNull}}">
                 <ListBox.ItemContainerStyle>
diff --git a/Desktop/Pages/SelectCast.xaml.cs b/Desktop/Pages/SelectCast.xaml.cs
index bea83441..22937707 100644
--- a/Desktop/Pages/SelectCast.xaml.cs
+++ b/Desktop/Pages/SelectCast.xaml.cs
@@ -435,11 +435,41 @@ private async Task RemoveFromList(IList list, Applicant[] applicants)
                 overlay.Dispose();
         }
 
-        private void availableList_MouseDoubleClick(object sender, MouseButtonEventArgs e)
-            => addButton_Click(sender, e);
+        private void List_MouseDoubleClick(object sender, MouseButtonEventArgs e)
+        {
+            var list_box = (ListBox)sender;
+            if (list_box.SelectedItem is not Applicant applicant)
+                return;
+            if (selectionList.SelectedItem is CastGroup cg)
+            {
+                //view.ShowDetailsWindow(connection, afr, Window.GetWindow(this), criterias, auditionEngine);
+                e.Handled = true;
+            }
+            else if (selectionList.SelectedItem is AlternativeCast ac)
+            {
+                e.Handled = true;
+            }
+            else if (selectionList.SelectedItem is Tag tag)
+            {
+                e.Handled = true;
+            }
+        }
 
-        private void selectedList_MouseDoubleClick(object sender, MouseButtonEventArgs e)
-            => removeButton_Click(sender, e);
+        //public void ShowDetailsWindow(ShowConnection connection, ApplicantForRole afr, Window owner, Criteria[] criterias, IAuditionEngine audition_engine)
+        //{
+        //    if (!detailsWindows.TryGetValue(afr, out var window) || window.IsClosed)
+        //    {
+        //        window = new ApplicantDetailsWindow(connection, criterias, audition_engine, afr)
+        //        {
+        //            Owner = owner
+        //        };
+        //        detailsWindows[afr] = window;
+        //        window.Show();
+        //    }
+        //    if (window.WindowState == WindowState.Minimized)
+        //        window.WindowState = WindowState.Normal;
+        //    window.Activate();
+        //}
 
         private void castStatusCombo_SelectionChanged(object sender, SelectionChangedEventArgs e)
             => ConfigureAllApplicantsFiltering();
@@ -491,12 +521,6 @@ private static void RemoveFromSameCastSet(SameCastSet set, Applicant[] applicant
             }
         }
 
-        private void availableSameCastSetList_MouseDoubleClick(object sender, MouseButtonEventArgs e)
-            => addSameCastSetButton_Click(sender, e);
-
-        private void selectedSameCastSetList_MouseDoubleClick(object sender, MouseButtonEventArgs e)
-            => removeSameCastSetButton_Click(sender, e);
-
         private void selectionList_SelectionChanged(object sender, SelectionChangedEventArgs e)
         {
             if (suitabilityComparer != null)

From 9a91b5702cdb80b8883b79473c2e103d06f66f36 Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 07:33:48 +1100
Subject: [PATCH 5/8] Implement ApplicantForCastGroup

---
 Desktop/Pages/SelectCast.xaml.cs            | 93 +++++++++++++--------
 Desktop/ViewModels/ApplicantForCastGroup.cs | 49 +++++++++++
 Desktop/ViewModels/ApplicantForSelection.cs | 45 ++++++++++
 3 files changed, 150 insertions(+), 37 deletions(-)
 create mode 100644 Desktop/ViewModels/ApplicantForCastGroup.cs
 create mode 100644 Desktop/ViewModels/ApplicantForSelection.cs

diff --git a/Desktop/Pages/SelectCast.xaml.cs b/Desktop/Pages/SelectCast.xaml.cs
index 22937707..28e18a4d 100644
--- a/Desktop/Pages/SelectCast.xaml.cs
+++ b/Desktop/Pages/SelectCast.xaml.cs
@@ -64,9 +64,13 @@ public partial class SelectCast : SubPage
         private Tag[] tags => _tags
             ?? throw new ApplicationException($"Tried to used {nameof(tags)} before it was loaded.");
 
-        private ISelectionEngine? _engine;
-        private ISelectionEngine engine => _engine
-            ?? throw new ApplicationException($"Tried to used {nameof(engine)} before it was loaded.");
+        private IAuditionEngine? _auditionEngine;
+        private IAuditionEngine auditionEngine => _auditionEngine
+            ?? throw new ApplicationException($"Tried to used {nameof(auditionEngine)} before it was loaded.");
+
+        private ISelectionEngine? _selectionEngine;
+        private ISelectionEngine selectionEngine => _selectionEngine
+            ?? throw new ApplicationException($"Tried to used {nameof(selectionEngine)} before it was loaded.");
 
         private CastList? _castList;
         private CastList castList => _castList
@@ -141,22 +145,22 @@ private async void Page_Loaded(object sender, RoutedEventArgs e)
             using (loading.Segment(nameof(ISelectionEngine), "Selection engine"))
             {
                 var show_root = context.ShowRoot;
-                IAuditionEngine audition_engine = ParseAuditionEngine() switch
+                _auditionEngine = ParseAuditionEngine() switch
                 {
                     nameof(NeuralAuditionEngine) => new NeuralAuditionEngine(criterias, NeuralEngineConfirm),
                     nameof(WeightedSumEngine) => new WeightedSumEngine(criterias),
                     _ => throw new ArgumentException($"Audition engine not handled: {ParseAuditionEngine()}")
                 };
-                applicantDescription.AuditionEngine = audition_engine;
-                _engine = suitabilityCalculator.SelectionEngine = ParseSelectionEngine() switch
+                applicantDescription.AuditionEngine = _auditionEngine;
+                _selectionEngine = suitabilityCalculator.SelectionEngine = ParseSelectionEngine() switch
                 {
-                    nameof(HeuristicSelectionEngine) => new HeuristicSelectionEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection),
-                    nameof(ChunkedPairsSatEngine) => new ChunkedPairsSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
-                    nameof(TopPairsSatEngine) => new TopPairsSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
-                    nameof(ThreesACrowdSatEngine) => new ThreesACrowdSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
-                    nameof(HybridPairsSatEngine) => new HybridPairsSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
-                    nameof(RankDifferenceSatEngine) => new RankDifferenceSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
-                    nameof(BestPairsSatEngine) => new BestPairsSatEngine(audition_engine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(HeuristicSelectionEngine) => new HeuristicSelectionEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection),
+                    nameof(ChunkedPairsSatEngine) => new ChunkedPairsSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(TopPairsSatEngine) => new TopPairsSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(ThreesACrowdSatEngine) => new ThreesACrowdSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(HybridPairsSatEngine) => new HybridPairsSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(RankDifferenceSatEngine) => new RankDifferenceSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
+                    nameof(BestPairsSatEngine) => new BestPairsSatEngine(_auditionEngine, alternativeCasts, show_root.CastNumberOrderBy, show_root.CastNumberOrderDirection, criterias),
                     _ => throw new ArgumentException($"Allocation engine not handled: {ParseSelectionEngine()}")
                 };
             }
@@ -191,9 +195,9 @@ protected override async Task<bool> PreSaveChecks()
                     using (var processing = new LoadingOverlay(this).AsSegment(nameof(SelectCast) + nameof(PreSaveChecks), "Processing..."))
                     {
                         using (processing.Segment(nameof(ISelectionEngine.BalanceAlternativeCasts), "Balancing alternating casts"))
-                            await engine.BalanceAlternativeCasts(applicants, context.SameCastSets.Local);
+                            await selectionEngine.BalanceAlternativeCasts(applicants, context.SameCastSets.Local);
                         using (processing.Segment(nameof(ISelectionEngine.AllocateCastNumbers), "Allocating cast numbers"))
-                            await engine.AllocateCastNumbers(applicants);
+                            await selectionEngine.AllocateCastNumbers(applicants);
                     }
                     var updated_inconsistent_applicants = applicants
                         .Where(a => a.CastGroup is CastGroup cg && (a.CastNumber == null || cg.AlternateCasts != (a.AlternativeCast != null)));
@@ -211,7 +215,7 @@ protected override async Task<bool> PreSaveChecks()
                 }
             }
             using (new LoadingOverlay(this).AsSegment(nameof(IAuditionEngine) + nameof(IAuditionEngine.UserSelectedCast), "Learning...", "Cast selected by the user"))
-                await engine.UserSelectedCast(applicants.Where(a => a.IsAccepted), applicants.Where(a => !a.IsAccepted));
+                await selectionEngine.UserSelectedCast(applicants.Where(a => a.IsAccepted), applicants.Where(a => !a.IsAccepted));
             return true;
         }
 
@@ -230,28 +234,28 @@ private async void selectCastButton_Click(object sender, RoutedEventArgs e)
                 if (settings.SelectCastGroups == true)
                     ClearCastGroups();
                 if (settings.SelectCastGroups != false)
-                    await engine.SelectCastGroups(applicants, castGroups);
+                    await selectionEngine.SelectCastGroups(applicants, castGroups);
             }
             using (processing.Segment(nameof(ISelectionEngine.BalanceAlternativeCasts), "Balancing alternating casts"))
             {
                 if (settings.BalanceAlternativeCasts == true)
                     ClearAlternativeCasts();
                 if (settings.BalanceAlternativeCasts != false)
-                    await engine .BalanceAlternativeCasts(applicants, context.SameCastSets.Local);
+                    await selectionEngine .BalanceAlternativeCasts(applicants, context.SameCastSets.Local);
             }
             using (processing.Segment(nameof(ISelectionEngine.AllocateCastNumbers), "Allocating cast numbers"))
             {
                 if (settings.AllocateCastNumbers == true)
                     ClearCastNumbers();
                 if (settings.AllocateCastNumbers != false)
-                    await engine.AllocateCastNumbers(applicants);
+                    await selectionEngine.AllocateCastNumbers(applicants);
             }
             using (processing.Segment(nameof(ISelectionEngine.ApplyTags), "Applying tags"))
             {
                 if (settings.ApplyTags == true)
                     ClearTags();
                 if (settings.ApplyTags != false)
-                    await engine.ApplyTags(applicants, tags);
+                    await selectionEngine.ApplyTags(applicants, tags);
             }
         }
 
@@ -437,39 +441,53 @@ private async Task RemoveFromList(IList list, Applicant[] applicants)
 
         private void List_MouseDoubleClick(object sender, MouseButtonEventArgs e)
         {
+            //TODO changing the selection status via >/>>/</<< doesn't update details window
             var list_box = (ListBox)sender;
             if (list_box.SelectedItem is not Applicant applicant)
                 return;
             if (selectionList.SelectedItem is CastGroup cg)
             {
-                //view.ShowDetailsWindow(connection, afr, Window.GetWindow(this), criterias, auditionEngine);
+                ShowDetailsWindow(new ApplicantForCastGroup(applicant, criterias, cg));
                 e.Handled = true;
             }
             else if (selectionList.SelectedItem is AlternativeCast ac)
             {
+                //TODO ApplicantForAlternativeCast
                 e.Handled = true;
             }
             else if (selectionList.SelectedItem is Tag tag)
             {
+                //TODO ApplicantForAlternativeTag
                 e.Handled = true;
             }
         }
 
-        //public void ShowDetailsWindow(ShowConnection connection, ApplicantForRole afr, Window owner, Criteria[] criterias, IAuditionEngine audition_engine)
-        //{
-        //    if (!detailsWindows.TryGetValue(afr, out var window) || window.IsClosed)
-        //    {
-        //        window = new ApplicantDetailsWindow(connection, criterias, audition_engine, afr)
-        //        {
-        //            Owner = owner
-        //        };
-        //        detailsWindows[afr] = window;
-        //        window.Show();
-        //    }
-        //    if (window.WindowState == WindowState.Minimized)
-        //        window.WindowState = WindowState.Normal;
-        //    window.Activate();
-        //}
+        Dictionary<Applicant, ApplicantDetailsWindow> detailsWindows = new();
+
+        void CloseDetailsWindows() //TODO exiting page by any means needs to close applicant details windows
+        {
+            foreach (var window in detailsWindows.Values)
+            {
+                window.Close();
+            }
+            detailsWindows.Clear();
+        }
+
+        void ShowDetailsWindow(ApplicantForSelection afs)
+        {
+            if (!detailsWindows.TryGetValue(afs.Applicant, out var window) || window.IsClosed)
+            {
+                window = new ApplicantDetailsWindow(connection, criterias, auditionEngine, afs)
+                {
+                    Owner = Window.GetWindow(this)
+                };
+                detailsWindows[afs.Applicant] = window;
+                window.Show();
+            }
+            if (window.WindowState == WindowState.Minimized)
+                window.WindowState = WindowState.Normal;
+            window.Activate();
+        }
 
         private void castStatusCombo_SelectionChanged(object sender, SelectionChangedEventArgs e)
             => ConfigureAllApplicantsFiltering();
@@ -525,6 +543,7 @@ private void selectionList_SelectionChanged(object sender, SelectionChangedEvent
         {
             if (suitabilityComparer != null)
                 suitabilityComparer.SelectedCastGroupOrTag = selectionList.SelectedItem;
+            CloseDetailsWindows();
             RefreshMainPanel();
         }
 
@@ -590,7 +609,7 @@ private async void DetectSiblings_Click(object sender, RoutedEventArgs e)
         {
             IEnumerable<SameCastSet> new_same_cast_sets;
             using (new LoadingOverlay(this).AsSegment(nameof(SelectCast) + nameof(PreSaveChecks), "Processing...", "Detecting siblings"))
-                new_same_cast_sets = await engine.DetectFamilies(applicants);
+                new_same_cast_sets = await selectionEngine.DetectFamilies(applicants);
             var list = (IList)sameCastSetsViewSource.Source;
             foreach (var new_same_cast_set in new_same_cast_sets)
                 list.Add(new_same_cast_set);
diff --git a/Desktop/ViewModels/ApplicantForCastGroup.cs b/Desktop/ViewModels/ApplicantForCastGroup.cs
new file mode 100644
index 00000000..cb346ec2
--- /dev/null
+++ b/Desktop/ViewModels/ApplicantForCastGroup.cs
@@ -0,0 +1,49 @@
+using Carmen.ShowModel.Applicants;
+using Carmen.ShowModel.Criterias;
+using Carmen.ShowModel.Structure;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Carmen.Desktop.ViewModels
+{
+    internal class ApplicantForCastGroup : ApplicantForSelection
+    {
+        readonly CastGroup castGroup;
+
+        public override string SelectionText => $"Select {FirstName} into {castGroup.Name}";
+
+        public override bool IsSelected
+        {
+            get => castGroup.Members.Contains(Applicant);
+            set
+            {
+                if (value)
+                {
+                    if (!castGroup.Members.Contains(Applicant))
+                    {
+                        Applicant.CastGroup = castGroup;
+                        castGroup.Members.Add(Applicant);
+                    }
+                }
+                else
+                {
+                    if (castGroup.Members.Contains(Applicant))
+                    {
+                        Applicant.CastGroup = null;
+                        castGroup.Members.Remove(Applicant);
+                    }   
+                }
+                OnPropertyChanged();
+            }
+        }
+
+        public ApplicantForCastGroup(Applicant applicant, Criteria[] criterias, CastGroup cast_group)
+            : base(applicant, criterias)
+        {
+            castGroup = cast_group;
+        }
+    }
+}
diff --git a/Desktop/ViewModels/ApplicantForSelection.cs b/Desktop/ViewModels/ApplicantForSelection.cs
new file mode 100644
index 00000000..7b1d5543
--- /dev/null
+++ b/Desktop/ViewModels/ApplicantForSelection.cs
@@ -0,0 +1,45 @@
+using Carmen.CastingEngine.Allocation;
+using Carmen.ShowModel.Applicants;
+using Carmen.ShowModel.Criterias;
+using Carmen.ShowModel.Structure;
+using System;
+using System.Collections.Generic;
+using System.ComponentModel;
+using System.Data;
+using System.Linq;
+using System.Runtime.CompilerServices;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Carmen.Desktop.ViewModels
+{
+    public abstract class ApplicantForSelection : ISelectableApplicant, INotifyPropertyChanged
+    {
+        public Applicant Applicant { get; init; }
+        public Criteria[] PrimaryCriterias { get; init; }
+
+        public event PropertyChangedEventHandler? PropertyChanged;
+
+        public abstract bool IsSelected { get; set; }
+
+        public string FirstName => Applicant.FirstName;
+        public string LastName => Applicant.LastName;
+
+        public IEnumerable<string> ExistingRoles => Enumerable.Empty<string>();
+        public IEnumerable<string> UnavailabilityReasons => Enumerable.Empty<string>(); //TODO anything to populate here?
+        public IEnumerable<string> IneligibilityReasons => Enumerable.Empty<string>(); //TODO anything to populate here?
+
+        public abstract string SelectionText { get; }
+
+        public ApplicantForSelection(Applicant applicant, Criteria[] criterias)
+        {
+            Applicant = applicant;
+            PrimaryCriterias = criterias; // all criterias are useful at the selection phase, not just primary
+        }
+
+        protected void OnPropertyChanged([CallerMemberName] string? name = null)
+        {
+            PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(name));
+        }
+    }
+}

From 22ed929a13b44f4c13b42c50dca6c3815dd4ce35 Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 07:39:27 +1100
Subject: [PATCH 6/8] Implement ApplicantForTag/AlternativeCast

---
 Desktop/Pages/SelectCast.xaml.cs              |  4 +-
 .../ViewModels/ApplicantForAlternativeCast.cs | 49 +++++++++++++++++++
 Desktop/ViewModels/ApplicantForTag.cs         | 47 ++++++++++++++++++
 3 files changed, 98 insertions(+), 2 deletions(-)
 create mode 100644 Desktop/ViewModels/ApplicantForAlternativeCast.cs
 create mode 100644 Desktop/ViewModels/ApplicantForTag.cs

diff --git a/Desktop/Pages/SelectCast.xaml.cs b/Desktop/Pages/SelectCast.xaml.cs
index 28e18a4d..d91dc8ca 100644
--- a/Desktop/Pages/SelectCast.xaml.cs
+++ b/Desktop/Pages/SelectCast.xaml.cs
@@ -452,12 +452,12 @@ private void List_MouseDoubleClick(object sender, MouseButtonEventArgs e)
             }
             else if (selectionList.SelectedItem is AlternativeCast ac)
             {
-                //TODO ApplicantForAlternativeCast
+                ShowDetailsWindow(new ApplicantForAlternativeCast(applicant, criterias, ac));
                 e.Handled = true;
             }
             else if (selectionList.SelectedItem is Tag tag)
             {
-                //TODO ApplicantForAlternativeTag
+                ShowDetailsWindow(new ApplicantForTag(applicant, criterias, tag));
                 e.Handled = true;
             }
         }
diff --git a/Desktop/ViewModels/ApplicantForAlternativeCast.cs b/Desktop/ViewModels/ApplicantForAlternativeCast.cs
new file mode 100644
index 00000000..88035fc1
--- /dev/null
+++ b/Desktop/ViewModels/ApplicantForAlternativeCast.cs
@@ -0,0 +1,49 @@
+using Carmen.ShowModel.Applicants;
+using Carmen.ShowModel.Criterias;
+using Carmen.ShowModel.Structure;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Carmen.Desktop.ViewModels
+{
+    internal class ApplicantForAlternativeCast : ApplicantForSelection
+    {
+        readonly AlternativeCast alternativeCast;
+
+        public override string SelectionText => $"Assign {FirstName} to {alternativeCast.Name}";
+
+        public override bool IsSelected
+        {
+            get => alternativeCast.Members.Contains(Applicant);
+            set
+            {
+                if (value)
+                {
+                    if (!alternativeCast.Members.Contains(Applicant))
+                    {
+                        Applicant.AlternativeCast = alternativeCast;
+                        alternativeCast.Members.Add(Applicant);
+                    }
+                }
+                else
+                {
+                    if (alternativeCast.Members.Contains(Applicant))
+                    {
+                        Applicant.AlternativeCast = null;
+                        alternativeCast.Members.Remove(Applicant);
+                    }
+                }
+                OnPropertyChanged();
+            }
+        }
+
+        public ApplicantForAlternativeCast(Applicant applicant, Criteria[] criterias, AlternativeCast alternative_cast)
+            : base(applicant, criterias)
+        {
+            alternativeCast = alternative_cast;
+        }
+    }
+}
diff --git a/Desktop/ViewModels/ApplicantForTag.cs b/Desktop/ViewModels/ApplicantForTag.cs
new file mode 100644
index 00000000..df556f73
--- /dev/null
+++ b/Desktop/ViewModels/ApplicantForTag.cs
@@ -0,0 +1,47 @@
+using Carmen.ShowModel.Applicants;
+using Carmen.ShowModel.Criterias;
+using Carmen.ShowModel.Structure;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Carmen.Desktop.ViewModels
+{
+    internal class ApplicantForTag : ApplicantForSelection
+    {
+        readonly Tag tag;
+
+        public override string SelectionText => $"Apply {tag.Name} to {FirstName}";
+
+        public override bool IsSelected
+        {
+            get => tag.Members.Contains(Applicant);
+            set
+            {
+                if (value)
+                {
+                    if (!tag.Members.Contains(Applicant))
+                    {
+                        tag.Members.Add(Applicant);
+                    }
+                }
+                else
+                {
+                    if (tag.Members.Contains(Applicant))
+                    {
+                        tag.Members.Remove(Applicant);
+                    }
+                }
+                OnPropertyChanged();
+            }
+        }
+
+        public ApplicantForTag(Applicant applicant, Criteria[] criterias, Tag tag)
+            : base(applicant, criterias)
+        {
+            this.tag = tag;
+        }
+    }
+}

From a12cc79fe5689d1543e2aaec0bd526d9d78e7f68 Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 07:49:44 +1100
Subject: [PATCH 7/8] Close windows when leaving page

---
 Desktop/Pages/SelectCast.xaml.cs            | 8 +++++++-
 Desktop/ViewModels/ApplicantForSelection.cs | 4 ++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Desktop/Pages/SelectCast.xaml.cs b/Desktop/Pages/SelectCast.xaml.cs
index d91dc8ca..57e5d167 100644
--- a/Desktop/Pages/SelectCast.xaml.cs
+++ b/Desktop/Pages/SelectCast.xaml.cs
@@ -464,7 +464,7 @@ private void List_MouseDoubleClick(object sender, MouseButtonEventArgs e)
 
         Dictionary<Applicant, ApplicantDetailsWindow> detailsWindows = new();
 
-        void CloseDetailsWindows() //TODO exiting page by any means needs to close applicant details windows
+        void CloseDetailsWindows()
         {
             foreach (var window in detailsWindows.Values)
             {
@@ -489,6 +489,12 @@ void ShowDetailsWindow(ApplicantForSelection afs)
             window.Activate();
         }
 
+        protected override void DisposeInternal()
+        {
+            CloseDetailsWindows();
+            base.DisposeInternal();
+        }
+
         private void castStatusCombo_SelectionChanged(object sender, SelectionChangedEventArgs e)
             => ConfigureAllApplicantsFiltering();
 
diff --git a/Desktop/ViewModels/ApplicantForSelection.cs b/Desktop/ViewModels/ApplicantForSelection.cs
index 7b1d5543..cb6c8e5c 100644
--- a/Desktop/ViewModels/ApplicantForSelection.cs
+++ b/Desktop/ViewModels/ApplicantForSelection.cs
@@ -26,8 +26,8 @@ public abstract class ApplicantForSelection : ISelectableApplicant, INotifyPrope
         public string LastName => Applicant.LastName;
 
         public IEnumerable<string> ExistingRoles => Enumerable.Empty<string>();
-        public IEnumerable<string> UnavailabilityReasons => Enumerable.Empty<string>(); //TODO anything to populate here?
-        public IEnumerable<string> IneligibilityReasons => Enumerable.Empty<string>(); //TODO anything to populate here?
+        public IEnumerable<string> UnavailabilityReasons => Enumerable.Empty<string>();
+        public IEnumerable<string> IneligibilityReasons => Enumerable.Empty<string>(); //TODO populate ineligability
 
         public abstract string SelectionText { get; }
 

From e6a6b085c88910982e3456381999fc1504255bcd Mon Sep 17 00:00:00 2001
From: David Lang <davidlang42@gmail.com>
Date: Tue, 28 Nov 2023 08:16:44 +1100
Subject: [PATCH 8/8] Dont allow changing of selection within applicant details
 because the lists don't update properly and a major refactor would be
 required to fix it

---
 Desktop/Converters/CollapsedIfNull.cs         | 30 ++++++++++++
 Desktop/Pages/SelectCast.xaml.cs              | 33 +++----------
 .../ViewModels/ApplicantForAlternativeCast.cs | 49 -------------------
 Desktop/ViewModels/ApplicantForCastGroup.cs   | 49 -------------------
 Desktop/ViewModels/ApplicantForRole.cs        |  2 +-
 Desktop/ViewModels/ApplicantForSelection.cs   | 12 +++--
 Desktop/ViewModels/ApplicantForTag.cs         | 47 ------------------
 Desktop/ViewModels/ISelectableApplicant.cs    |  2 +-
 Desktop/Windows/ApplicantDetailsWindow.xaml   |  3 +-
 9 files changed, 49 insertions(+), 178 deletions(-)
 create mode 100644 Desktop/Converters/CollapsedIfNull.cs
 delete mode 100644 Desktop/ViewModels/ApplicantForAlternativeCast.cs
 delete mode 100644 Desktop/ViewModels/ApplicantForCastGroup.cs
 delete mode 100644 Desktop/ViewModels/ApplicantForTag.cs

diff --git a/Desktop/Converters/CollapsedIfNull.cs b/Desktop/Converters/CollapsedIfNull.cs
new file mode 100644
index 00000000..e146399d
--- /dev/null
+++ b/Desktop/Converters/CollapsedIfNull.cs
@@ -0,0 +1,30 @@
+using System;
+using System.Collections.Generic;
+using System.Globalization;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using System.Windows;
+using System.Windows.Data;
+
+namespace Carmen.Desktop.Converters
+{
+    /// <summary>
+    /// Convert an object value to a Visibility based on whether or not it is null.
+    /// If ConverterParameter is set to a type, then the value must be this type to be considered not null.
+    /// </summary>
+    public class CollapsedIfNull : IValueConverter
+    {
+        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+        {
+            if (value == null)
+                return Visibility.Collapsed;
+            if (parameter is Type type && !(value.GetType() == type || value.GetType().IsSubclassOf(type)))
+                return Visibility.Collapsed;
+            return Visibility.Visible;
+        }
+
+        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+            => throw new NotImplementedException();
+    }
+}
diff --git a/Desktop/Pages/SelectCast.xaml.cs b/Desktop/Pages/SelectCast.xaml.cs
index 57e5d167..be5b9cf2 100644
--- a/Desktop/Pages/SelectCast.xaml.cs
+++ b/Desktop/Pages/SelectCast.xaml.cs
@@ -441,38 +441,16 @@ private async Task RemoveFromList(IList list, Applicant[] applicants)
 
         private void List_MouseDoubleClick(object sender, MouseButtonEventArgs e)
         {
-            //TODO changing the selection status via >/>>/</<< doesn't update details window
             var list_box = (ListBox)sender;
-            if (list_box.SelectedItem is not Applicant applicant)
-                return;
-            if (selectionList.SelectedItem is CastGroup cg)
-            {
-                ShowDetailsWindow(new ApplicantForCastGroup(applicant, criterias, cg));
-                e.Handled = true;
-            }
-            else if (selectionList.SelectedItem is AlternativeCast ac)
+            if (list_box.SelectedItem is Applicant applicant)
             {
-                ShowDetailsWindow(new ApplicantForAlternativeCast(applicant, criterias, ac));
-                e.Handled = true;
-            }
-            else if (selectionList.SelectedItem is Tag tag)
-            {
-                ShowDetailsWindow(new ApplicantForTag(applicant, criterias, tag));
+                ShowDetailsWindow(new ApplicantForSelection(applicant, criterias));
                 e.Handled = true;
             }
         }
 
         Dictionary<Applicant, ApplicantDetailsWindow> detailsWindows = new();
 
-        void CloseDetailsWindows()
-        {
-            foreach (var window in detailsWindows.Values)
-            {
-                window.Close();
-            }
-            detailsWindows.Clear();
-        }
-
         void ShowDetailsWindow(ApplicantForSelection afs)
         {
             if (!detailsWindows.TryGetValue(afs.Applicant, out var window) || window.IsClosed)
@@ -491,7 +469,11 @@ void ShowDetailsWindow(ApplicantForSelection afs)
 
         protected override void DisposeInternal()
         {
-            CloseDetailsWindows();
+            foreach (var window in detailsWindows.Values)
+            {
+                window.Close();
+            }
+            detailsWindows.Clear();
             base.DisposeInternal();
         }
 
@@ -549,7 +531,6 @@ private void selectionList_SelectionChanged(object sender, SelectionChangedEvent
         {
             if (suitabilityComparer != null)
                 suitabilityComparer.SelectedCastGroupOrTag = selectionList.SelectedItem;
-            CloseDetailsWindows();
             RefreshMainPanel();
         }
 
diff --git a/Desktop/ViewModels/ApplicantForAlternativeCast.cs b/Desktop/ViewModels/ApplicantForAlternativeCast.cs
deleted file mode 100644
index 88035fc1..00000000
--- a/Desktop/ViewModels/ApplicantForAlternativeCast.cs
+++ /dev/null
@@ -1,49 +0,0 @@
-using Carmen.ShowModel.Applicants;
-using Carmen.ShowModel.Criterias;
-using Carmen.ShowModel.Structure;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Carmen.Desktop.ViewModels
-{
-    internal class ApplicantForAlternativeCast : ApplicantForSelection
-    {
-        readonly AlternativeCast alternativeCast;
-
-        public override string SelectionText => $"Assign {FirstName} to {alternativeCast.Name}";
-
-        public override bool IsSelected
-        {
-            get => alternativeCast.Members.Contains(Applicant);
-            set
-            {
-                if (value)
-                {
-                    if (!alternativeCast.Members.Contains(Applicant))
-                    {
-                        Applicant.AlternativeCast = alternativeCast;
-                        alternativeCast.Members.Add(Applicant);
-                    }
-                }
-                else
-                {
-                    if (alternativeCast.Members.Contains(Applicant))
-                    {
-                        Applicant.AlternativeCast = null;
-                        alternativeCast.Members.Remove(Applicant);
-                    }
-                }
-                OnPropertyChanged();
-            }
-        }
-
-        public ApplicantForAlternativeCast(Applicant applicant, Criteria[] criterias, AlternativeCast alternative_cast)
-            : base(applicant, criterias)
-        {
-            alternativeCast = alternative_cast;
-        }
-    }
-}
diff --git a/Desktop/ViewModels/ApplicantForCastGroup.cs b/Desktop/ViewModels/ApplicantForCastGroup.cs
deleted file mode 100644
index cb346ec2..00000000
--- a/Desktop/ViewModels/ApplicantForCastGroup.cs
+++ /dev/null
@@ -1,49 +0,0 @@
-using Carmen.ShowModel.Applicants;
-using Carmen.ShowModel.Criterias;
-using Carmen.ShowModel.Structure;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Carmen.Desktop.ViewModels
-{
-    internal class ApplicantForCastGroup : ApplicantForSelection
-    {
-        readonly CastGroup castGroup;
-
-        public override string SelectionText => $"Select {FirstName} into {castGroup.Name}";
-
-        public override bool IsSelected
-        {
-            get => castGroup.Members.Contains(Applicant);
-            set
-            {
-                if (value)
-                {
-                    if (!castGroup.Members.Contains(Applicant))
-                    {
-                        Applicant.CastGroup = castGroup;
-                        castGroup.Members.Add(Applicant);
-                    }
-                }
-                else
-                {
-                    if (castGroup.Members.Contains(Applicant))
-                    {
-                        Applicant.CastGroup = null;
-                        castGroup.Members.Remove(Applicant);
-                    }   
-                }
-                OnPropertyChanged();
-            }
-        }
-
-        public ApplicantForCastGroup(Applicant applicant, Criteria[] criterias, CastGroup cast_group)
-            : base(applicant, criterias)
-        {
-            castGroup = cast_group;
-        }
-    }
-}
diff --git a/Desktop/ViewModels/ApplicantForRole.cs b/Desktop/ViewModels/ApplicantForRole.cs
index 406eecd1..4b4eed93 100644
--- a/Desktop/ViewModels/ApplicantForRole.cs
+++ b/Desktop/ViewModels/ApplicantForRole.cs
@@ -97,7 +97,7 @@ public IEnumerable<string> UnavailabilityReasons
 
         public string CommaSeparatedIneligibilityReason => string.Join(", ", IneligibilityReasons);
 
-        public string SelectionText => $"Allocate {RoleName} to {FirstName}";
+        public string? SelectionText => $"Allocate {RoleName} to {FirstName}";
 
         public ApplicantForRole(IAllocationEngine engine, Applicant applicant, Role role, Criteria[] primary_criterias)
         {
diff --git a/Desktop/ViewModels/ApplicantForSelection.cs b/Desktop/ViewModels/ApplicantForSelection.cs
index cb6c8e5c..793b6c72 100644
--- a/Desktop/ViewModels/ApplicantForSelection.cs
+++ b/Desktop/ViewModels/ApplicantForSelection.cs
@@ -13,23 +13,27 @@
 
 namespace Carmen.Desktop.ViewModels
 {
-    public abstract class ApplicantForSelection : ISelectableApplicant, INotifyPropertyChanged
+    public class ApplicantForSelection : ISelectableApplicant, INotifyPropertyChanged
     {
         public Applicant Applicant { get; init; }
         public Criteria[] PrimaryCriterias { get; init; }
 
         public event PropertyChangedEventHandler? PropertyChanged;
 
-        public abstract bool IsSelected { get; set; }
+        public bool IsSelected
+        {
+            get => true; // so that colour images are shown
+            set => throw new InvalidOperationException();
+        }
 
         public string FirstName => Applicant.FirstName;
         public string LastName => Applicant.LastName;
 
         public IEnumerable<string> ExistingRoles => Enumerable.Empty<string>();
         public IEnumerable<string> UnavailabilityReasons => Enumerable.Empty<string>();
-        public IEnumerable<string> IneligibilityReasons => Enumerable.Empty<string>(); //TODO populate ineligability
+        public IEnumerable<string> IneligibilityReasons => Enumerable.Empty<string>();
 
-        public abstract string SelectionText { get; }
+        public string? SelectionText => null; // this hides the checkbox completely
 
         public ApplicantForSelection(Applicant applicant, Criteria[] criterias)
         {
diff --git a/Desktop/ViewModels/ApplicantForTag.cs b/Desktop/ViewModels/ApplicantForTag.cs
deleted file mode 100644
index df556f73..00000000
--- a/Desktop/ViewModels/ApplicantForTag.cs
+++ /dev/null
@@ -1,47 +0,0 @@
-using Carmen.ShowModel.Applicants;
-using Carmen.ShowModel.Criterias;
-using Carmen.ShowModel.Structure;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Carmen.Desktop.ViewModels
-{
-    internal class ApplicantForTag : ApplicantForSelection
-    {
-        readonly Tag tag;
-
-        public override string SelectionText => $"Apply {tag.Name} to {FirstName}";
-
-        public override bool IsSelected
-        {
-            get => tag.Members.Contains(Applicant);
-            set
-            {
-                if (value)
-                {
-                    if (!tag.Members.Contains(Applicant))
-                    {
-                        tag.Members.Add(Applicant);
-                    }
-                }
-                else
-                {
-                    if (tag.Members.Contains(Applicant))
-                    {
-                        tag.Members.Remove(Applicant);
-                    }
-                }
-                OnPropertyChanged();
-            }
-        }
-
-        public ApplicantForTag(Applicant applicant, Criteria[] criterias, Tag tag)
-            : base(applicant, criterias)
-        {
-            this.tag = tag;
-        }
-    }
-}
diff --git a/Desktop/ViewModels/ISelectableApplicant.cs b/Desktop/ViewModels/ISelectableApplicant.cs
index 096657f7..3f836236 100644
--- a/Desktop/ViewModels/ISelectableApplicant.cs
+++ b/Desktop/ViewModels/ISelectableApplicant.cs
@@ -15,7 +15,7 @@ public interface ISelectableApplicant
         bool IsSelected { get; set; }
         string FirstName { get; }
         string LastName { get; }
-        string SelectionText { get; }
+        string? SelectionText { get; }
         IEnumerable<string> ExistingRoles { get; }
         IEnumerable<string> UnavailabilityReasons { get; }
         IEnumerable<string> IneligibilityReasons { get; }
diff --git a/Desktop/Windows/ApplicantDetailsWindow.xaml b/Desktop/Windows/ApplicantDetailsWindow.xaml
index a1c86395..f9a6cdf7 100644
--- a/Desktop/Windows/ApplicantDetailsWindow.xaml
+++ b/Desktop/Windows/ApplicantDetailsWindow.xaml
@@ -24,6 +24,7 @@
             <BooleanToVisibilityConverter/>
         </cv:MultiConverter>
         <BooleanToVisibilityConverter x:Key="showIfTrue"/>
+        <cv:CollapsedIfNull x:Key="collapsedIfNull"/>
     </Window.Resources>
     <Grid>
         <Grid.ColumnDefinitions>
@@ -157,7 +158,7 @@
             </StackPanel>
         </ScrollViewer>
         <Grid Grid.Row="2" Margin="5">
-            <CheckBox IsChecked="{Binding IsSelected}">
+            <CheckBox IsChecked="{Binding IsSelected}" Visibility="{Binding SelectionText, Converter={StaticResource collapsedIfNull}}">
                 <TextBlock>
                     <Run Text="{Binding SelectionText, Mode=OneWay}"/>
                 </TextBlock>