--prof-viz extra flame graph based on v8 prof data #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would this work on windows? |
|
Yes. I'll do it as a next step |
davidmarkclements
force-pushed
the
prof-viz
branch
from
18fa3eb
to
ab874d7
Compare
added 2 commits
February 8, 2018 18:53
|
ok here's the plan. release --prof-viz as the new minor – no windows support make prof the default stack source for 0x v4, this will be the first 0x to support Windows. It also means 0x will work by default with zero configuration inside VM's and containers. v4 will support this will lead to the following compatibility map
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comments welcome
@mafintosh @BridgeAR @lucamaraschi @mcollina