Improved knockout binding #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the initialization of the multiselect by waiting for other select related bindings to finish first. Moved the subscription to other binder events to init so they aren't re-executed all the time. Added support for value binding. Added support for observable configuration properties. Observable subscription rate-limited (by @IDisposable). Simplified how selection changes are processed (simpler code, not sure about performance).
|
Thanks! Would you also add some documentation of how to use the plugin with knockout? - This is still missing as I am not familiar with Knockout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the initialization of the multiselect by waiting for other select related bindings to finish first.
Moved the subscription to other binder events to init so they aren't re-executed all the time.
Added support for value binding.
Added support for observable configuration properties.
Observable subscription rate-limited (by @IDisposable).
Simplified how selection changes are processed (simpler code, not sure about performance).