From feeb588ada7a2c81422cbaf7f39bcf2067a8c4b4 Mon Sep 17 00:00:00 2001 From: davilu <45977130+davilu@users.noreply.github.com> Date: Thu, 17 Dec 2020 18:43:05 -0800 Subject: [PATCH] [8982026] fix metrics e2e test (#4125) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * fixed metrics description * fixed UT ConnectionManagerTest by adding missing mock which impacted by metrics change * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla * modified to use Array.Empty * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * fixed typo in md file Co-authored-by: Venkat Yalla --- doc/BuiltInMetrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/BuiltInMetrics.md b/doc/BuiltInMetrics.md index 7b44a32da27..103b790e76f 100644 --- a/doc/BuiltInMetrics.md +++ b/doc/BuiltInMetrics.md @@ -40,7 +40,7 @@ instance_number | A Guid representing the current runtime. On restart, all metri | `edgehub_operation_retry_total` | `id` (Module ID)
`operation` (Operation name) | Total number of times edgeHub operations were retried | counter | | `edgehub_client_connect_failed_total` | `id` (Device/Module ID)
`reason` (not authenticated)
| Total number of times each client failed to connect to edgeHub | counter | | `edgehub_connected_clients` | | Current number of clients connected to edgeHub | gauge | -| `edgehub_client_connect_success_total` | `id` (Device/Module ID)
| Total number of times each client successfully connected to edgeHub | counter | | counter | +| `edgehub_client_connect_success_total` | `id` (Device/Module ID)
| Total number of times each client successfully connected to edgeHub | counter | | `edgehub_client_disconnect_total` | `id` (Device/Module ID)
| Total number of times each client disconnected from edgeHub | counter |