From c697b345578aa6d67f30dd952f05947cc4bb35e3 Mon Sep 17 00:00:00 2001
From: Kimo Knowles <kimo.knowles@day8.com.au>
Date: Mon, 3 Jul 2023 12:37:26 +0200
Subject: [PATCH] [refactor] Dispatch an epoch's scroll effect in a ref
 callback

---
 .../re_frame_10x/navigation/epochs/views.cljs | 61 ++++++++-----------
 1 file changed, 27 insertions(+), 34 deletions(-)

diff --git a/src/day8/re_frame_10x/navigation/epochs/views.cljs b/src/day8/re_frame_10x/navigation/epochs/views.cljs
index 75a8dc36..e02471b2 100644
--- a/src/day8/re_frame_10x/navigation/epochs/views.cljs
+++ b/src/day8/re_frame_10x/navigation/epochs/views.cljs
@@ -34,40 +34,33 @@
 
 (defn epoch
   []
-  (let [hover?     (r/atom false)
-        active?    (r/atom false)]
-    (r/create-class
-      {:component-did-mount
-       (fn [this]
-         (when @active?
-           (rf/dispatch [::epochs.events/scroll-into-view-debounced (rdom/dom-node this)])))
-
-       :reagent-render
-       (fn [event id]
-         (let [ambiance   @(rf/subscribe [::settings.subs/ambiance])
-               current-id @(rf/subscribe [::epochs.subs/selected-epoch-id])]
-           (reset! active? (= id current-id))
-           [rc/h-box
-            :class      (epoch-style ambiance @active?)
-            :align      :start
-            :min-height styles/gs-19s
-            :attr       {:on-click       #(when-not @active? (rf/dispatch [::epochs.events/load id]))
-                         :on-mouse-enter #(reset! hover? true)
-                         :on-mouse-leave #(reset! hover? false)}
-            :children
-            [[rc/box
-              :class  (epoch-chevron-style ambiance @active? @hover?)
-              :height styles/gs-19s
-              :align  :center
-              :child
-              [material/chevron-right
-               {:size "17px"}]]
-             [rc/gap-f :size styles/gs-2s]
-             [rc/box
-              :class      (epoch-data-style ambiance)
-              :min-height styles/gs-19s
-              :size       "1"
-              :child      [cljs-devtools/simple-render event [id]]]]]))})))
+  (let [hover?     (r/atom false)]
+    (fn [event id]
+      (let [ambiance   @(rf/subscribe [::settings.subs/ambiance])
+            active?    (= id @(rf/subscribe [::epochs.subs/selected-epoch-id]))]
+        [rc/h-box
+         :class      (epoch-style ambiance active?)
+         :align      :start
+         :min-height styles/gs-19s
+         :attr       {:ref            #(when active?
+                                         (rf/dispatch [::epochs.events/scroll-into-view-debounced %]))
+                      :on-click       #(when-not active? (rf/dispatch [::epochs.events/load id]))
+                      :on-mouse-enter #(reset! hover? true)
+                      :on-mouse-leave #(reset! hover? false)}
+         :children
+         [[rc/box
+           :class  (epoch-chevron-style ambiance active? @hover?)
+           :height styles/gs-19s
+           :align  :center
+           :child
+           [material/chevron-right
+            {:size "17px"}]]
+          [rc/gap-f :size styles/gs-2s]
+          [rc/box
+           :class      (epoch-data-style ambiance)
+           :min-height styles/gs-19s
+           :size       "1"
+           :child      [cljs-devtools/simple-render event [id]]]]]))))
 
 (defclass epochs-style
   [ambiance]