Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16 #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #16 #49

wants to merge 1 commit into from

Conversation

drakmail
Copy link
Contributor

@drakmail drakmail commented Apr 9, 2020

Create db-migrate schema before creation of migrations table to fix #16

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: 016a8ff
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@drakmail
Copy link
Contributor Author

drakmail commented Apr 9, 2020

PS. Seems that travis-ci build is broken

@drakmail
Copy link
Contributor Author

I'm fixed travis-ci issue in #50

@wzrdtales
Copy link
Member

thank you for your contribution!

have to check on the dependencies if this has any side effects.

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: b5daad4
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: fcf9f26
    • ✖ message may not be empty
      , - ✖ type may not be empty
  • Commit: 397bf4d
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Create schema for migrations table before creation of migrations table
if the schema not exists

Signed-off-by: Alexander Maslov <alex@maslov.dev>
@drakmail
Copy link
Contributor Author

I'm rebased over the master branch, so tests now is passed (and also fixed a bug)

@wzrdtales
Copy link
Member

a little late, however, this would effectively change the schema, which is not an intended behavior. if you by any chance look again at this. do you know what was your intention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated 'migrations' table when using schemas
2 participants