Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ISO date & time #61

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add support for ISO date & time #61

merged 1 commit into from
Nov 20, 2023

Conversation

mathroule
Copy link
Collaborator

@mathroule mathroule commented Sep 28, 2023

Changes

Example

  • 2023-09-28
  • 2023-09-28Z
  • 2023-09-28T21:59:56Z

@dblock
Copy link
Owner

dblock commented Sep 29, 2023

Great! We need to re-enable CI in this project since Travis CI is MIA. Care to do it? Separate PR probably best. You can use a token for Danger from something like https://github.com/dblock/ruby-enum.

@mathroule
Copy link
Collaborator Author

Great! We need to re-enable CI in this project since Travis CI is MIA. Care to do it? Separate PR probably best. You can use a token for Danger from something like https://github.com/dblock/ruby-enum.

Done in #62

@mathroule
Copy link
Collaborator Author

@dblock the branch is up to date with the new CI checks. Do you mind reviewing the PR? Thanks

@dblock dblock merged commit 751df62 into dblock:master Nov 20, 2023
@dblock
Copy link
Owner

dblock commented Nov 20, 2023

Merged, thank you!

Any interest in co-maintaining danger-changelog? Maybe make a release with this change? If yes drop me a note to dblock at dblock dot org with your rubygems username.

@mathroule mathroule deleted the support-iso-datetime branch November 20, 2023 13:30
@mathroule
Copy link
Collaborator Author

Yes, I would be happy to get a new release of danger-changelog. Thanks

My RubyGems username is https://rubygems.org/profiles/mathroule.

@dblock
Copy link
Owner

dblock commented Nov 20, 2023

Added you here and Rubygems @mathroule, accept the GitHub invite here: https://github.com/dblock/danger-changelog/invitations

Please follow https://github.com/dblock/danger-changelog/blob/master/RELEASING.md for a release. Let's first increment the version to 0.7.0 since this was a new feature, too? https://github.com/dblock/danger-changelog/blob/master/lib/changelog/gem_version.rb#L2, CHANGELOG, etc.

@mathroule
Copy link
Collaborator Author

mathroule commented Nov 21, 2023

Thanks for adding me @dblock.
I released version 0.7.0 on RubyGems: https://rubygems.org/gems/danger-changelog.
I also updated GitHub releases: https://github.com/dblock/danger-changelog/releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants