-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model contracts + constraints with nested fields #738
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
Opened a follow-up tech debt issue to adopt this convention + implementation in dbt-core at some point in the future: dbt-labs/dbt-core#7759. Presently, BigQuery's support of nested columns + constraints is most maturely supported and keeping the implementation focused on BigQuery will prevent a large scope increase of this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks fine (though I'm not completely familiar). There's a failing functional test which might be related though.
The failing integration test looks related to some recently merged changes for fixes to foreign key rendering that made the base test a little less generic than it previously was. I have a fix in another PR related to constraints but will move it out into its own PR to unblock this work. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-738-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b1e950bf6f8f6c3528b65080e257b746839ef87c
# Push it to GitHub
git push --set-upstream origin backport-738-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
(cherry picked from commit b1e950b)
resolves #673
Description
🎩
Fixing the incorrect data type,
dbt run
passes ✅Checklist
changie new
to create a changelog entry