From 34d8ac7c6eba12e8d88b9de90a01c03b062a0fb6 Mon Sep 17 00:00:00 2001 From: Emily Rockman Date: Mon, 8 Jan 2024 15:08:43 -0600 Subject: [PATCH] Update implementation-ticket.yml (#9349) * Update implementation-ticket.yml * Update .github/ISSUE_TEMPLATE/implementation-ticket.yml * fix key --- .github/ISSUE_TEMPLATE/implementation-ticket.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/implementation-ticket.yml b/.github/ISSUE_TEMPLATE/implementation-ticket.yml index e5bfaaa45e5..dd22441cd22 100644 --- a/.github/ISSUE_TEMPLATE/implementation-ticket.yml +++ b/.github/ISSUE_TEMPLATE/implementation-ticket.yml @@ -30,6 +30,16 @@ body: What is the definition of done for this ticket? Include any relevant edge cases and/or test cases validations: required: true + - type: textarea + attributes: + label: Suggested Tests + description: | + Provide scenarios to test. Link to existing similar tests if appropriate. + placeholder: | + 1. Test with no version specified in the schema file and use selection logic on a versioned model for a specific version. Expect pass. + 2. Test with a version specified in the schema file that is no valid. Expect ParsingError. + validations: + required: true - type: textarea attributes: label: Impact to Other Teams @@ -53,6 +63,5 @@ body: label: Context description: | Provide the "why", motivation, and alternative approaches considered -- linking to previous refinement issues, spikes, Notion docs as appropriate - validations: validations: required: false