add a pretty janky data test to expose quoting issues

dbt-labs · Apr 16, 2019 · fc4fc57 · fc4fc57
1 parent d515903
commit fc4fc57
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/test/integration/001_simple_copy_test/test_simple_copy.py b/test/integration/001_simple_copy_test/test_simple_copy.py
@@ -17,6 +17,7 @@ def models(self):
 
 
 class TestSimpleCopy(BaseTestSimpleCopy):
+
     @use_profile("postgres")
     def test__postgres__simple_copy(self):
         self.use_default_project({"data-paths": [self.dir("seed-initial")]})
@@ -83,6 +84,12 @@ def test__snowflake__simple_copy(self):
 
         self.assertManyTablesEqual(["SEED", "VIEW_MODEL", "INCREMENTAL", "MATERIALIZED"])
 
+        self.use_default_project({
+            "test-paths": [self.dir("tests")],
+            "data-paths": [self.dir("seed-update")],
+        })
+        self.run_dbt(['test'])
+
     @use_profile("snowflake")
     def test__snowflake__simple_copy__quoting_off(self):
         self.use_default_project({
@@ -108,6 +115,13 @@ def test__snowflake__simple_copy__quoting_off(self):
 
         self.assertManyTablesEqual(["SEED", "VIEW_MODEL", "INCREMENTAL", "MATERIALIZED"])
 
+        self.use_default_project({
+            "test-paths": [self.dir("tests")],
+            "data-paths": [self.dir("seed-update")],
+            "quoting": {"identifier": False},
+        })
+        self.run_dbt(['test'])
+
     @use_profile("snowflake")
     def test__snowflake__seed__quoting_switch(self):
         self.use_default_project({
@@ -124,6 +138,12 @@ def test__snowflake__seed__quoting_switch(self):
         })
         results = self.run_dbt(["seed"], expect_pass=False)
 
+        self.use_default_project({
+            "test-paths": [self.dir("tests")],
+            "data-paths": [self.dir("seed-initial")],
+        })
+        self.run_dbt(['test'])
+
     @use_profile("bigquery")
     def test__bigquery__simple_copy(self):
         self.use_default_project({"data-paths": [self.dir("seed-initial")]})
@@ -181,6 +201,8 @@ def test__snowflake__simple_copy__quoting_on(self):
 
         self.assertManyTablesEqual(["seed", "view_model", "incremental", "materialized"])
 
+        # can't run the test as this one's identifiers will be the wrong case
+
 
 class BaseLowercasedSchemaTest(BaseTestSimpleCopy):
     def unique_schema(self):
@@ -210,6 +232,12 @@ def test__snowflake__simple_copy(self):
 
         self.assertManyTablesEqual(["SEED", "VIEW_MODEL", "INCREMENTAL", "MATERIALIZED"])
 
+        self.use_default_project({
+            "test-paths": [self.dir("tests")],
+            "data-paths": [self.dir("seed-update")],
+        })
+        self.run_dbt(['test'])
+
 
 class TestSnowflakeSimpleLowercasedSchemaQuoted(BaseLowercasedSchemaTest):
     @property

diff --git a/test/integration/001_simple_copy_test/tests/get_relation_quoting.sql b/test/integration/001_simple_copy_test/tests/get_relation_quoting.sql
@@ -0,0 +1,9 @@
+{%- set tgt = ref('seed') -%}
+{%- set got = adapter.get_relation(database=tgt.database, schema=tgt.schema, identifier=tgt.identifier) | string -%}
+{% set replaced = got.replace('"', '-') %}
+{% set expected = "-" + tgt.database.upper() + '-.-' + tgt.schema.upper() + '-.-' + tgt.identifier.upper() + '-' %}
+
+with cte as (
+    select '{{ replaced }}' as name
+)
+select * from cte where name not like '{{ expected }}'