-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1350] Clean up string formatting #6068
Comments
Hi |
Can I help with this one? |
I think this command finds all the files that contain cases that match the examples in the first comment on this issue (with a few false positives): fd '.py$' | xargs grep -Ei '(.*"\s+".*)|(.*"\s+f".*)' | awk '{print $1}' | sort | uniq | sed -E 's/(.*):/\1/'
|
Working on this one for the hackathon |
+1 |
@luke-bassett script is a great way to go! The |
Looks like @eve-johns has covered f-strings. This command still has a couple false positives, but fewer. fd '.py$' | xargs grep -Ei '.*".*"\s+".*".*' | awk '{print $1}' | sort | uniq | sed -E 's/(.*):/\1/' I'm making the changes now. |
Ah I didn't noticed there are also plain strings problem. Trying regx |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers. |
Describe the feature
Clean up the strings in
dbt-core
.When we originally mass formatted our code with black, it caused some weird formatting that does not matter to Python but is not how it should be.
Examples:
dbt-core/core/dbt/adapters/base/impl.py
Lines 583 to 585 in 9b84b6e
dbt-core/core/dbt/config/project.py
Lines 670 to 672 in 9b84b6e
Searching the code for
" f"
finds many. The first example is harder to find as there are legitimate parts of the code with empty strings. It is still doable however.Describe alternatives you've considered
Doing it as we touch these areas of code.
Who will this benefit?
Anyone looking at the code who is irked by this formatting.
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: