Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2568] Script to create jsonschemas includes unneeded definitions in the schema #7604

Closed
gshank opened this issue May 11, 2023 · 1 comment
Closed

[CT-2568] Script to create jsonschemas includes unneeded definitions in the schema #7604

gshank opened this issue May 11, 2023 · 1 comment
Labels
artifacts tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@gshank
Copy link
Contributor

gshank commented May 11, 2023

When running the scripts/collect-artifact-schema.py script, if WriteableManifest shows up before the other schema classes in the list, the subsequent schemas include unnecessary definitions (such as ManifestMetadata, etc). It looks like the "definitions" in hologram are being persisted across calls to the jsons_schema method.

This was encountered in #7590. Another ticket was opened to specify a single artifact to build: #7599.
@github-actions github-actions bot changed the title Script to create jsonschemas includes unneeded definitions in the schema [CT-2568] Script to create jsonschemas includes unneeded definitions in the schema May 11, 2023
@jtcohen6 jtcohen6 added artifacts tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels May 11, 2023
@emmyoop
Copy link
Member

emmyoop commented Jun 5, 2023

Closing in favor of #6776

@emmyoop emmyoop closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
artifacts tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gshank @emmyoop @jtcohen6