Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add builder config to test node config #10767

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

colin-rogers-dbt
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 24, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (b590045) to head (45339c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10767      +/-   ##
==========================================
- Coverage   89.07%   88.21%   -0.87%     
==========================================
  Files         182      182              
  Lines       23288    23294       +6     
==========================================
- Hits        20744    20549     -195     
- Misses       2544     2745     +201     
Flag Coverage Δ
integration 84.78% <100.00%> (-1.51%) ⬇️
unit 62.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.22% <100.00%> (+<0.01%) ⬆️
Integration Tests 84.78% <100.00%> (-1.51%) ⬇️

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review September 25, 2024 22:43
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner September 25, 2024 22:43
@colin-rogers-dbt
Copy link
Contributor Author

@colin-rogers-dbt colin-rogers-dbt self-assigned this Sep 25, 2024
@colin-rogers-dbt colin-rogers-dbt changed the title add builder config to node config add builder config to test node config Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant